Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heapless does not build for riscv32imc-unknown-none-elf target #123

Closed
rjoleary opened this issue Nov 15, 2019 · 2 comments · Fixed by #135
Closed

heapless does not build for riscv32imc-unknown-none-elf target #123

rjoleary opened this issue Nov 15, 2019 · 2 comments · Fixed by #135

Comments

@rjoleary
Copy link

rv32imc does not have atomics leading to this issue:

error[E0599]: no method named `compare_exchange_weak` found for type `core::sync::atomic::AtomicPtr<pool::Node<T>>` in the current scope
   --> /home/ryan/.cargo/registry/src/github.com-1ecc6299db9ec823/heapless-0.4.4/src/pool/mod.rs:278:33
    |
278 |                 match self.head.compare_exchange_weak(
    |                                 ^^^^^^^^^^^^^^^^^^^^^ method not found in `core::sync::atomic::AtomicPtr<pool::Node<T>>`
@jamesmunns
Copy link
Member

I believe this would be closed by #120.

@japaric
Copy link
Member

japaric commented Dec 17, 2019

I believe this would be closed by #120.

That PR is not sufficient. That target does not have atomic loads either so AtomicUsize et al. are missing from core meaning that the spsc module doesn't compile for this target even after disabling the "cas" Cargo feature.

bors bot added a commit that referenced this issue Dec 17, 2019
135: remove spsc / pool / mpmc modules on targets w/o atomic / CAS support r=japaric a=japaric

closes #123

Co-authored-by: Jorge Aparicio <[email protected]>
bors bot added a commit that referenced this issue Dec 18, 2019
135: remove spsc / pool / mpmc modules on targets w/o atomic / CAS support r=japaric a=japaric

closes #123

Co-authored-by: Jorge Aparicio <[email protected]>
@bors bors bot closed this as completed in 44c66a7 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants