Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #339

Merged
merged 3 commits into from
May 31, 2021
Merged

fix typo #339

merged 3 commits into from
May 31, 2021

Conversation

dzvon
Copy link
Contributor

@dzvon dzvon commented May 25, 2021

No description provided.

@dzvon dzvon requested a review from a team as a code owner May 25, 2021 02:40
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels May 25, 2021
@dzvon
Update README.md
b877f28 
fix typo.
eldruin
eldruin approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

bors r+

bors bot added a commit that referenced this pull request May 25, 2021
@bors @dzvon
Merge #339
cde2689 
339: fix typo r=eldruin a=dzvon



Co-authored-by: Dezhi Wu <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 25, 2021

Build failed:

@eldruin
Copy link
Member

eldruin commented May 25, 2021

Ach, we are hitting the same problem here as in #337

eldruin
eldruin approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it should work. Thank you!

bors r+

@bors
Copy link
Contributor

bors bot commented May 31, 2021

Build succeeded:

@bors bors bot merged commit cc254bb into rust-embedded:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzvon @rust-highfive @eldruin @adamgreig