Fixed typos regarding .cargo/config.toml
#337
Conversation
The file keeps on being referred to as either `cargo/config.toml` or `.cargo/config.toml`. This PR corrects all of them to `.cargo/config.toml`
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
337: Fixed typos regarding `.cargo/config.toml` r=adamgreig a=rdelfin The file keeps on being referred to as either `cargo/config.toml` or `.cargo/config.toml`. This PR corrects all of them to `.cargo/config.toml` Co-authored-by: Ricardo Delfin <[email protected]>
|
Build failed: |
|
bors retry |
337: Fixed typos regarding `.cargo/config.toml` r=adamgreig a=rdelfin The file keeps on being referred to as either `cargo/config.toml` or `.cargo/config.toml`. This PR corrects all of them to `.cargo/config.toml` Co-authored-by: Ricardo Delfin <[email protected]>
|
Build failed: |
|
Huh, that's more worrying. Not your fault though, will investigate. |
|
The wonders of CI |
It looks like depending on two panic handlers ( Removing the dependencies on |
|
@adamgreig and @rdelfin is there anything speaking against removing In case you have no objections how to proceed? Should I create a PR against your branch @rdelfin? Our would you simply pick the commit? |
|
If that's enough to get it working please do go ahead with a PR, probably against master is easiest since we can merge that first and then when we retry these other PRs, they will be tested against the merged version. |
|
I'd be glad to rebase on top of that change after it merges, given that's probably the easiest option! |
|
I'm sorry, but it looks like I had a mental blackout late at night when writing #337 (comment). My proposal fixes #267 and #341 already propose actually suitable changes and you already pointed out in the latter that there is some real work ahead @adamgreig. I will have a look if I could contribute something to these PRs. |
The file keeps on being referred to as either
cargo/config.tomlor.cargo/config.toml. This PR corrects all of them to.cargo/config.toml