(Dev.) Options to control fall-back reasons and post-exec simplification #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `--fallback-on REASON1,REASON2,...` allows users to set a custom set of reasons on which a fall-back to kore-rpc will be performed. The default is `Branching,Stuck,Aborted` (behaviour as before). * `--no-post-exec-simplify` switches off the post-exec simplification with kore-rpc (booster results will always be simplified with booster's simplifier before returning). Both options are meant for developer experimentation. In particular, it is probably not sensible to not have `Aborted` in the `fallback-on` set of halt reasons.
geo2a
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
@jberthold I've allowed myself to push a commit that changes how the default abort reasons are displayed in --help, so that they look the same as the option format.
rv-jenkins
deleted the
434-options-for-fallback-reasons-and-post-exec-simplify
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434
--fallback-on REASON1,REASON2,...allows users to set a custom set of reasons on which a fall-back to kore-rpc will be performed. The default isBranching,Stuck,Aborted(behaviour as before).--no-post-exec-simplifyswitches off the post-exec simplification with kore-rpc (booster results will always be simplified with booster's simplifier before returning).Both options are meant for developer experimentation. In particular, it is probably not sensible to not have
Abortedin thefallback-onset of halt reasons.