-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable options for controlling booster execution #2243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mption to KEVM proofs
It looks like you and Andrei have had some back and forth on this one. Is there an ETA to merge this one? |
anvacaru
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a typo fix. 👍
Co-authored-by: Andrei Văcaru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: runtimeverification/pyk#804Blocked on: #2236Blocked on: #2269This PR takes advantage of a few new features introduced in pyk, and makes a few updates to CLI and testing options:
--fast-check-subsumption
allows a faster way to check that a node will definitely not be subsumed into the target.--always-check-subsumption
allows checking even non-terminal node for subsumption.--[no-]post-exec-simplify
allows telling the booster to not call the old backend to simplify states that it produces before handing them back to pyk (see (Dev.) Options to control fall-back reasons and post-exec simplification hs-backend-booster#436).--fallback-on
allows the user to specify the fallback reasons the booster will consider (see (Dev.) Options to control fall-back reasons and post-exec simplification hs-backend-booster#436).--interim-simplification
allows the user to specify how frequently to invoke the full simplifier on the execution state.break_on_calls
set toTrue
for testing/CI behavior, butFalse
for CLI behavior, which made it hard to track down a bug.--spec-name
is added tomake test-prove-pyk ...
pytest testsuite, which allows filtering for a specific specification to run in the testing harness environment (much faster to narrow down to specific test that way).