Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add finch vm status command #83

Merged
merged 25 commits into from
Jan 17, 2023
Merged

feat: add finch vm status command #83

merged 25 commits into from
Jan 17, 2023

Conversation

niklasmtj
Copy link
Contributor

@niklasmtj niklasmtj commented Dec 2, 2022 •
edited by ningziwen
Loading

Issue #, if available: #23

Description of changes:
Adding the finch vm status command.

Testing done:
make && make lint && make test-unit since I did not yet updated the e2e tests where I need help to understand how to test the command

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@niklasmtj
Feature: Add vm status command
dca252d 
Signed-off-by: Niklas Metje <[email protected]>
@niklasmtj
Refactor: Update run to call internal status func
bce5bd6 
Signed-off-by: Niklas Metje <[email protected]>
@niklasmtj
Merge branch 'runfinch:main' into feature/vm-status-command
936c3ae
@niklasmtj
Merge branch 'feature/vm-status-command' of github.com:niklasmtj/finc…
c12ffe3 
…h into feature/vm-status-command
@niklasmtj
Fix: Update to stdout prints
49bd274 
Signed-off-by: Niklas Metje <[email protected]>
@niklasmtj
Feature: Add vm status command
83c2ab4 
Signed-off-by: Niklas Metje <[email protected]>
@niklasmtj
Refactor: Update run to call internal status func
5f70bbc 
Signed-off-by: Niklas Metje <[email protected]>
@niklasmtj
Fix: Update to stdout prints
dd613a2 
Signed-off-by: Niklas Metje <[email protected]>
@niklasmtj
Merge branch 'feature/vm-status-command' of github.com:niklasmtj/finc…
a023908 
…h into feature/vm-status-command
@niklasmtj
Move files to cmd/finch/ directory
97024a6 
Signed-off-by: Niklas Metje <[email protected]>
@ningziwen ningziwen self-requested a review December 2, 2022 18:46
@ningziwen ningziwen self-assigned this Dec 2, 2022
@weikequ weikequ added the enhancement New feature or request label Dec 2, 2022
@weikequ weikequ linked an issue Dec 2, 2022 that may be closed by this pull request
Cannot see finch VM status #23
Closed
@ningziwen
Copy link
Member

We also need e2e tests here.

@niklasmtj niklasmtj changed the title Feature add finch vm status command feat: add finch vm status command Dec 3, 2022
@niklasmtj
fix: apply pr feedback
d1cfc5f 
Signed-off-by: Niklas Metje <[email protected]>
@ningziwen
Copy link
Member

ningziwen commented Dec 7, 2022 •
edited
Loading

@niklasmtj Hey I see you pushed one commit labeled "apply pr feedback". We are still waiting for the changes of addressing other comments. Whenever you are ready, you can reply in the comments to let us know.

@niklasmtj
Copy link
Contributor Author

Hey, thanks. I will do that. Before that i have to get more into the mock testing. But will to this in the next couple of days.

@niklasmtj
Copy link
Contributor Author

niklasmtj commented Dec 17, 2022 •
edited
Loading

Hey, I think I might need a helping hand here. I'm pretty new to Golang and have a hard time figuring out how the mocking is done.
I did try to use the tests from the start or stop command to get a grasp on how to do it. I also got a couple of tests that are green but to be completely honest I don't know if this really tests the method in the right way. I will push my current tests and would appreciate any guidance on how to do it. Thank you in advance!

If this PR takes too long you can also go forward and finish it. Reading the results would also help me a lot to understand how it have to be done :)

@ningziwen
Copy link
Member

Hey, I think I might need a helping hand here. I'm pretty new to Golang and have a hard time figuring out how the mocking is done. I did try to use the tests from the start or stop command to get a grasp on how to do it. I also got a couple of tests that are green but to be completely honest I don't know if this really tests the method in the right way. I will push my current tests and would appreciate any guidance on how to do it. Thank you in advance!

If this PR takes too long you can also go forward and finish it. Reading the results would also help me a lot to understand how it have to be done :)

No rush for this change. I'm happy to use this PR to help you onboard Finch slowly. I will put comments in your existing change and give suggestions.

@ningziwen
Copy link
Member

Not a big deal but fyi :) https://github.com/runfinch/finch/blob/main/CONTRIBUTING.md?plain=1#L88

@niklasmtj
Copy link
Contributor Author

Oh I'm sorry, this makes sense. Did not know this. Were used to use it as a reference for me of the things to do :)

@davidhsingyuchen davidhsingyuchen mentioned this pull request Jan 9, 2023
Merged
1 task
@niklasmtj
Copy link
Contributor Author

Started with the e2e tests but still trying to understand how to implement the tests that makes the most sense. I was thinking about adding one per each When block to see if the status command is returning the desired output.

In terms of syntax can I use the testVersion as a reference point?

@davidhsingyuchen
Copy link
Contributor

davidhsingyuchen commented Jan 11, 2023 •
edited
Loading

@niklasmtj

I was thinking about adding one per each When block to see if the status command is returning the desired output.

If you're referring to adding an It block to in each When block in https://github.com/runfinch/finch/blob/main/e2e/virtual_machine_test.go, then I think it makes sense.

In terms of syntax can I use the testVersion as a reference point?

Sure. Every file in the e2e package should have a consistent style. If more references are needed, you can also take a look at https://github.com/runfinch/common-tests/tree/main/tests.

@niklasmtj
tests: add e2e tests
406e760 
Signed-off-by: Niklas Metje <[email protected]>
@niklasmtj niklasmtj requested review from ningziwen and davidhsingyuchen and removed request for ningziwen and davidhsingyuchen January 15, 2023 15:20
@niklasmtj
Copy link
Contributor Author

niklasmtj commented Jan 15, 2023 •
edited
Loading

Hey, just added the e2e tests and ran make && make lint && make test-unit && make test-e2e which passed successfully. Will have a look at the conflicts if I'm able to resolve them by myself. But I guess I will need a bit of help here 😀 Nevermind, seems to be an easier conflict than I thought. Testing it all through now.

davidhsingyuchen
davidhsingyuchen reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@davidhsingyuchen davidhsingyuchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM overall, just a minor comment. You can ignore the e2e test failure as it's likely caused by flakiness and is tracked in #140.

cmd/finch/virtual_machine_status_test.go Outdated Show resolved Hide resolved
@ningziwen ningziwen merged commit 37d74d0 into runfinch:main Jan 17, 2023
@github-actions github-actions bot mentioned this pull request Jan 17, 2023
Merged
sam-berning pushed a commit that referenced this pull request Jan 18, 2023
@github-actions
chore(main): release 0.3.0 (#148)
d4a0566 
🤖 I have created a release *beep* *boop*
---


## [0.3.0](v0.2.0...v0.3.0)
(2023-01-18)


### ⚠ BREAKING CHANGES

* changes persistent disk path to prevent collisions

### Features

* add `finch vm status` command
([#83](#83))
([37d74d0](37d74d0))


### Bug Fixes

* changes persistent disk path to prevent collisions
([3eb66a2](3eb66a2))


### Build System or External Dependencies

* **deps:** Bump github.com/onsi/gomega from 1.24.2 to 1.25.0
([#165](#165))
([e4b9e96](e4b9e96))
* **deps:** Bump github.com/runfinch/common-tests from 0.2.0 to 0.3.0
([#151](#151))
([79df04e](79df04e))
* **deps:** Bump github.com/runfinch/common-tests version from v0.3.0 to
v0.3.1 ([#169](#169))
([16157fe](16157fe))
* **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0
([#144](#144))
([603419a](603419a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@niklasmtj niklasmtj deleted the feature/vm-status-command branch January 20, 2023 19:29
vsiravar pushed a commit to vsiravar/finch-public that referenced this pull request Mar 20, 2023
@github-actions
chore(main): release 0.5.0 (#47)
bd155e0 
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](v0.4.1...v0.5.0)
(2023-03-20)


### ⚠ BREAKING CHANGES

* persists nerdctl user data
([runfinch#182](https://github.com/vsiravar/finch-public/issues/182))
* changes persistent disk path to prevent collisions

### Features

* add `finch cp` command
([runfinch#135](https://github.com/vsiravar/finch-public/issues/135))
([5989361](5989361))
* add `finch vm status` command
([runfinch#83](https://github.com/vsiravar/finch-public/issues/83))
([37d74d0](37d74d0))
* add config to support additional directories
([runfinch#128](https://github.com/vsiravar/finch-public/issues/128))
([0ceb060](0ceb060))
* adds a --force flag to vm stop and remove
([runfinch#178](https://github.com/vsiravar/finch-public/issues/178))
([d499a7d](d499a7d))
* Play with semver and revert
([#46](#46))
([2299e1e](2299e1e))
* Print version with Client and Server
([runfinch#108](https://github.com/vsiravar/finch-public/issues/108))
([7f7cdda](7f7cdda))
* saves containerd user data to a persistent disk
([runfinch#133](https://github.com/vsiravar/finch-public/issues/133))
([fccb4f3](fccb4f3))
* Support special IP host-gateway in --add-host flag
([runfinch#216](https://github.com/vsiravar/finch-public/issues/216))
([9a38c8e](9a38c8e))


### Bug Fixes

* changes persistent disk path to prevent collisions
([3eb66a2](3eb66a2))
* Configure Buildkit Namespace as Env Variable
([runfinch#129](https://github.com/vsiravar/finch-public/issues/129))
([ffb90be](ffb90be))
* correctly handle local environment value pass-through
([runfinch#158](https://github.com/vsiravar/finch-public/issues/158))
([e138f10](e138f10))
* error readable by using the right placeholder
([#39](#39))
([8e5f38d](8e5f38d))
* fix the misleading log when applying invalid config
([runfinch#119](https://github.com/vsiravar/finch-public/issues/119))
([b4f74c5](b4f74c5))
* ignore .ssh pub keys
([runfinch#109](https://github.com/vsiravar/finch-public/issues/109))
([0b74597](0b74597))
* parse --add-host special ip with equal sign
([runfinch#229](https://github.com/vsiravar/finch-public/issues/229))
([fb4b62b](fb4b62b))
* persists nerdctl user data
([runfinch#182](https://github.com/vsiravar/finch-public/issues/182))
([59f372c](59f372c))
* persists network user data
([runfinch#211](https://github.com/vsiravar/finch-public/issues/211))
([f6baf82](f6baf82))
* print debug logs after newline
([runfinch#273](https://github.com/vsiravar/finch-public/issues/273))
([8faa7de](8faa7de))
* print debug logs when lima disk command fails
([runfinch#270](https://github.com/vsiravar/finch-public/issues/270))
([78a3f50](78a3f50))
* switch from rootless containers to rootful containers
([runfinch#232](https://github.com/vsiravar/finch-public/issues/232))
([ae43a07](ae43a07))


### Build System or External Dependencies

* clean up finch-core _output directory in clean target
([runfinch#290](https://github.com/vsiravar/finch-public/issues/290))
([4684a95](4684a95))
* **deps:** bump finch-core to 0.1.1
([runfinch#93](https://github.com/vsiravar/finch-public/issues/93))
([3f3bce5](3f3bce5))
* **deps:** Bump github.com/containerd/containerd from 1.6.14 to 1.6.18
([runfinch#223](https://github.com/vsiravar/finch-public/issues/223))
([7480222](7480222))
* **deps:** Bump github.com/google/go-licenses from 1.5.0 to 1.6.0
([runfinch#168](https://github.com/vsiravar/finch-public/issues/168))
([bb5674c](bb5674c))
* **deps:** Bump github.com/lima-vm/lima from 0.12.0 to 0.13.0
([#40](#40))
([520cc7f](520cc7f))
* **deps:** Bump github.com/lima-vm/lima from 0.13.0 to 0.14.0
([runfinch#113](https://github.com/vsiravar/finch-public/issues/113))
([9b275bc](9b275bc))
* **deps:** Bump github.com/lima-vm/lima from 0.14.0 to 0.14.1
([runfinch#120](https://github.com/vsiravar/finch-public/issues/120))
([9dea794](9dea794))
* **deps:** Bump github.com/lima-vm/lima from 0.14.1 to 0.14.2
([runfinch#130](https://github.com/vsiravar/finch-public/issues/130))
([26b7b09](26b7b09))
* **deps:** bump github.com/lima-vm/lima from 0.14.2 to 0.15.0
([runfinch#247](https://github.com/vsiravar/finch-public/issues/247))
([007081e](007081e))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1
([#50](#50))
([fa108fd](fa108fd))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0
([runfinch#114](https://github.com/vsiravar/finch-public/issues/114))
([934521c](934521c))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1
([runfinch#121](https://github.com/vsiravar/finch-public/issues/121))
([becbc44](becbc44))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.7.0 to 2.7.1
([runfinch#193](https://github.com/vsiravar/finch-public/issues/193))
([7aaa381](7aaa381))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.7.1 to 2.8.0
([runfinch#200](https://github.com/vsiravar/finch-public/issues/200))
([596ed33](596ed33))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.8.0 to 2.8.3
([runfinch#233](https://github.com/vsiravar/finch-public/issues/233))
([1185372](1185372))
* **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.3 to 2.8.4
([runfinch#245](https://github.com/vsiravar/finch-public/issues/245))
([5e64716](5e64716))
* **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0
([runfinch#265](https://github.com/vsiravar/finch-public/issues/265))
([7e2d49e](7e2d49e))
* **deps:** bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1
([runfinch#285](https://github.com/vsiravar/finch-public/issues/285))
([d741a03](d741a03))
* **deps:** Bump github.com/onsi/gomega from 1.24.1 to 1.24.2
([runfinch#122](https://github.com/vsiravar/finch-public/issues/122))
([d8174ff](d8174ff))
* **deps:** Bump github.com/onsi/gomega from 1.24.2 to 1.25.0
([runfinch#165](https://github.com/vsiravar/finch-public/issues/165))
([e4b9e96](e4b9e96))
* **deps:** Bump github.com/onsi/gomega from 1.25.0 to 1.26.0
([runfinch#183](https://github.com/vsiravar/finch-public/issues/183))
([12661b7](12661b7))
* **deps:** Bump github.com/onsi/gomega from 1.26.0 to 1.27.1
([runfinch#234](https://github.com/vsiravar/finch-public/issues/234))
([cd43781](cd43781))
* **deps:** bump github.com/onsi/gomega from 1.27.1 to 1.27.2
([runfinch#246](https://github.com/vsiravar/finch-public/issues/246))
([863c51e](863c51e))
* **deps:** Bump github.com/runfinch/common-tests from 0.1.1 to 0.2.0
([runfinch#125](https://github.com/vsiravar/finch-public/issues/125))
([1bac92a](1bac92a))
* **deps:** Bump github.com/runfinch/common-tests from 0.2.0 to 0.3.0
([runfinch#151](https://github.com/vsiravar/finch-public/issues/151))
([79df04e](79df04e))
* **deps:** Bump github.com/runfinch/common-tests from 0.5.0 to 0.6.0
([runfinch#235](https://github.com/vsiravar/finch-public/issues/235))
([4a33a2e](4a33a2e))
* **deps:** bump github.com/runfinch/common-tests from 0.6.1 to 0.6.2
([runfinch#300](https://github.com/vsiravar/finch-public/issues/300))
([dd626a0](dd626a0))
* **deps:** Bump github.com/runfinch/common-tests version from v0.1.0 to
v0.1.1 ([runfinch#76](https://github.com/vsiravar/finch-public/issues/76))
([fd22d4a](fd22d4a))
* **deps:** Bump github.com/runfinch/common-tests version from v0.3.0 to
v0.3.1 ([runfinch#169](https://github.com/vsiravar/finch-public/issues/169))
([16157fe](16157fe))
* **deps:** Bump github.com/spf13/afero from 1.9.2 to 1.9.3
([#43](#43))
([bf0ad84](bf0ad84))
* **deps:** Bump github.com/spf13/afero from 1.9.3 to 1.9.4
([runfinch#241](https://github.com/vsiravar/finch-public/issues/241))
([58f26e6](58f26e6))
* **deps:** bump github.com/spf13/afero from 1.9.4 to 1.9.5
([runfinch#263](https://github.com/vsiravar/finch-public/issues/263))
([a0e277f](a0e277f))
* **deps:** Bump github.com/stretchr/testify from 1.8.0 to 1.8.1
([#44](#44))
([31c6d70](31c6d70))
* **deps:** bump github.com/stretchr/testify from 1.8.1 to 1.8.2
([runfinch#244](https://github.com/vsiravar/finch-public/issues/244))
([984af70](984af70))
* **deps:** Bump github.com/xorcare/pointer from 1.2.1 to 1.2.2
([#42](#42))
([8e83137](8e83137))
* **deps:** Bump golang.org/x/crypto from 0.1.0 to 0.3.0
([#49](#49))
([89826cf](89826cf))
* **deps:** Bump golang.org/x/crypto from 0.3.0 to 0.4.0
([runfinch#102](https://github.com/vsiravar/finch-public/issues/102))
([d2778e3](d2778e3))
* **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0
([runfinch#138](https://github.com/vsiravar/finch-public/issues/138))
([8d06eec](8d06eec))
* **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0
([runfinch#144](https://github.com/vsiravar/finch-public/issues/144))
([603419a](603419a))
* **deps:** Bump golang.org/x/crypto from 0.5.0 to 0.6.0
([runfinch#212](https://github.com/vsiravar/finch-public/issues/212))
([e1a36cf](e1a36cf))
* **deps:** bump golang.org/x/crypto from 0.6.0 to 0.7.0
([runfinch#264](https://github.com/vsiravar/finch-public/issues/264))
([ec1c07f](ec1c07f))
* **deps:** Bump golang.org/x/tools from 0.2.0 to 0.3.0
([#52](#52))
([27c8f24](27c8f24))
* **deps:** Bump golang.org/x/tools from 0.3.0 to 0.4.0
([runfinch#101](https://github.com/vsiravar/finch-public/issues/101))
([b3c4df1](b3c4df1))
* **deps:** Bump golang.org/x/tools from 0.4.0 to 0.5.0
([runfinch#139](https://github.com/vsiravar/finch-public/issues/139))
([89194dc](89194dc))
* **deps:** Bump golang.org/x/tools from 0.5.0 to 0.6.0
([runfinch#215](https://github.com/vsiravar/finch-public/issues/215))
([decf250](decf250))
* **deps:** bump golang.org/x/tools from 0.6.0 to 0.7.0
([runfinch#268](https://github.com/vsiravar/finch-public/issues/268))
([8072e39](8072e39))
* **deps:** Bump k8s.io/apimachinery from 0.25.2 to 0.25.4
([#51](#51))
([8f15779](8f15779))
* **deps:** Bump k8s.io/apimachinery from 0.25.4 to 0.26.0
([runfinch#115](https://github.com/vsiravar/finch-public/issues/115))
([e9084a4](e9084a4))
* **deps:** Bump k8s.io/apimachinery from 0.26.0 to 0.26.1
([runfinch#174](https://github.com/vsiravar/finch-public/issues/174))
([829b0bc](829b0bc))
* **deps:** bump k8s.io/apimachinery from 0.26.1 to 0.26.2
([runfinch#251](https://github.com/vsiravar/finch-public/issues/251))
([4a7268e](4a7268e))
* **deps:** bump k8s.io/apimachinery from 0.26.2 to 0.26.3
([runfinch#306](https://github.com/vsiravar/finch-public/issues/306))
([fe392cb](fe392cb))
* **deps:** Bump lima version
([runfinch#141](https://github.com/vsiravar/finch-public/issues/141))
([35da07d](35da07d))
* **deps:** Bump lima version
([runfinch#302](https://github.com/vsiravar/finch-public/issues/302))
([0269743](0269743))
* **deps:** Bump lima version
([runfinch#75](https://github.com/vsiravar/finch-public/issues/75))
([cfaa4f6](cfaa4f6))
* **deps:** Bump submodules
([runfinch#281](https://github.com/vsiravar/finch-public/issues/281))
([d4fd1f6](d4fd1f6))
* **deps:** Bump submodules
([runfinch#304](https://github.com/vsiravar/finch-public/issues/304))
([b38af9f](b38af9f))
* make finch-core a submodule instead of downloading archives
([runfinch#188](https://github.com/vsiravar/finch-public/issues/188))
([b08f588](b08f588))
* update os image versions
([runfinch#255](https://github.com/vsiravar/finch-public/issues/255))
([576765b](576765b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vsiravar pushed a commit to vsiravar/finch-public that referenced this pull request Mar 20, 2023
@github-actions
chore(main): release 0.6.0 (#48)
08fb3c5 
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](v0.5.0...v0.6.0)
(2023-03-20)


### ⚠ BREAKING CHANGES

* persists nerdctl user data
([runfinch#182](https://github.com/vsiravar/finch-public/issues/182))
* changes persistent disk path to prevent collisions

### Features

* add `finch cp` command
([runfinch#135](https://github.com/vsiravar/finch-public/issues/135))
([5989361](5989361))
* add `finch vm status` command
([runfinch#83](https://github.com/vsiravar/finch-public/issues/83))
([37d74d0](37d74d0))
* add config to support additional directories
([runfinch#128](https://github.com/vsiravar/finch-public/issues/128))
([0ceb060](0ceb060))
* adds a --force flag to vm stop and remove
([runfinch#178](https://github.com/vsiravar/finch-public/issues/178))
([d499a7d](d499a7d))
* Play with semver and revert
([#46](#46))
([2299e1e](2299e1e))
* Print version with Client and Server
([runfinch#108](https://github.com/vsiravar/finch-public/issues/108))
([7f7cdda](7f7cdda))
* saves containerd user data to a persistent disk
([runfinch#133](https://github.com/vsiravar/finch-public/issues/133))
([fccb4f3](fccb4f3))
* Support special IP host-gateway in --add-host flag
([runfinch#216](https://github.com/vsiravar/finch-public/issues/216))
([9a38c8e](9a38c8e))


### Bug Fixes

* changes persistent disk path to prevent collisions
([3eb66a2](3eb66a2))
* Configure Buildkit Namespace as Env Variable
([runfinch#129](https://github.com/vsiravar/finch-public/issues/129))
([ffb90be](ffb90be))
* correctly handle local environment value pass-through
([runfinch#158](https://github.com/vsiravar/finch-public/issues/158))
([e138f10](e138f10))
* error readable by using the right placeholder
([#39](#39))
([8e5f38d](8e5f38d))
* fix the misleading log when applying invalid config
([runfinch#119](https://github.com/vsiravar/finch-public/issues/119))
([b4f74c5](b4f74c5))
* ignore .ssh pub keys
([runfinch#109](https://github.com/vsiravar/finch-public/issues/109))
([0b74597](0b74597))
* parse --add-host special ip with equal sign
([runfinch#229](https://github.com/vsiravar/finch-public/issues/229))
([fb4b62b](fb4b62b))
* persists nerdctl user data
([runfinch#182](https://github.com/vsiravar/finch-public/issues/182))
([59f372c](59f372c))
* persists network user data
([runfinch#211](https://github.com/vsiravar/finch-public/issues/211))
([f6baf82](f6baf82))
* print debug logs after newline
([runfinch#273](https://github.com/vsiravar/finch-public/issues/273))
([8faa7de](8faa7de))
* print debug logs when lima disk command fails
([runfinch#270](https://github.com/vsiravar/finch-public/issues/270))
([78a3f50](78a3f50))
* switch from rootless containers to rootful containers
([runfinch#232](https://github.com/vsiravar/finch-public/issues/232))
([ae43a07](ae43a07))


### Build System or External Dependencies

* clean up finch-core _output directory in clean target
([runfinch#290](https://github.com/vsiravar/finch-public/issues/290))
([4684a95](4684a95))
* **deps:** bump finch-core to 0.1.1
([runfinch#93](https://github.com/vsiravar/finch-public/issues/93))
([3f3bce5](3f3bce5))
* **deps:** Bump github.com/containerd/containerd from 1.6.14 to 1.6.18
([runfinch#223](https://github.com/vsiravar/finch-public/issues/223))
([7480222](7480222))
* **deps:** Bump github.com/google/go-licenses from 1.5.0 to 1.6.0
([runfinch#168](https://github.com/vsiravar/finch-public/issues/168))
([bb5674c](bb5674c))
* **deps:** Bump github.com/lima-vm/lima from 0.12.0 to 0.13.0
([#40](#40))
([520cc7f](520cc7f))
* **deps:** Bump github.com/lima-vm/lima from 0.13.0 to 0.14.0
([runfinch#113](https://github.com/vsiravar/finch-public/issues/113))
([9b275bc](9b275bc))
* **deps:** Bump github.com/lima-vm/lima from 0.14.0 to 0.14.1
([runfinch#120](https://github.com/vsiravar/finch-public/issues/120))
([9dea794](9dea794))
* **deps:** Bump github.com/lima-vm/lima from 0.14.1 to 0.14.2
([runfinch#130](https://github.com/vsiravar/finch-public/issues/130))
([26b7b09](26b7b09))
* **deps:** bump github.com/lima-vm/lima from 0.14.2 to 0.15.0
([runfinch#247](https://github.com/vsiravar/finch-public/issues/247))
([007081e](007081e))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1
([#50](#50))
([fa108fd](fa108fd))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0
([runfinch#114](https://github.com/vsiravar/finch-public/issues/114))
([934521c](934521c))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1
([runfinch#121](https://github.com/vsiravar/finch-public/issues/121))
([becbc44](becbc44))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.7.0 to 2.7.1
([runfinch#193](https://github.com/vsiravar/finch-public/issues/193))
([7aaa381](7aaa381))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.7.1 to 2.8.0
([runfinch#200](https://github.com/vsiravar/finch-public/issues/200))
([596ed33](596ed33))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.8.0 to 2.8.3
([runfinch#233](https://github.com/vsiravar/finch-public/issues/233))
([1185372](1185372))
* **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.3 to 2.8.4
([runfinch#245](https://github.com/vsiravar/finch-public/issues/245))
([5e64716](5e64716))
* **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0
([runfinch#265](https://github.com/vsiravar/finch-public/issues/265))
([7e2d49e](7e2d49e))
* **deps:** bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1
([runfinch#285](https://github.com/vsiravar/finch-public/issues/285))
([d741a03](d741a03))
* **deps:** Bump github.com/onsi/gomega from 1.24.1 to 1.24.2
([runfinch#122](https://github.com/vsiravar/finch-public/issues/122))
([d8174ff](d8174ff))
* **deps:** Bump github.com/onsi/gomega from 1.24.2 to 1.25.0
([runfinch#165](https://github.com/vsiravar/finch-public/issues/165))
([e4b9e96](e4b9e96))
* **deps:** Bump github.com/onsi/gomega from 1.25.0 to 1.26.0
([runfinch#183](https://github.com/vsiravar/finch-public/issues/183))
([12661b7](12661b7))
* **deps:** Bump github.com/onsi/gomega from 1.26.0 to 1.27.1
([runfinch#234](https://github.com/vsiravar/finch-public/issues/234))
([cd43781](cd43781))
* **deps:** bump github.com/onsi/gomega from 1.27.1 to 1.27.2
([runfinch#246](https://github.com/vsiravar/finch-public/issues/246))
([863c51e](863c51e))
* **deps:** Bump github.com/runfinch/common-tests from 0.1.1 to 0.2.0
([runfinch#125](https://github.com/vsiravar/finch-public/issues/125))
([1bac92a](1bac92a))
* **deps:** Bump github.com/runfinch/common-tests from 0.2.0 to 0.3.0
([runfinch#151](https://github.com/vsiravar/finch-public/issues/151))
([79df04e](79df04e))
* **deps:** Bump github.com/runfinch/common-tests from 0.5.0 to 0.6.0
([runfinch#235](https://github.com/vsiravar/finch-public/issues/235))
([4a33a2e](4a33a2e))
* **deps:** bump github.com/runfinch/common-tests from 0.6.1 to 0.6.2
([runfinch#300](https://github.com/vsiravar/finch-public/issues/300))
([dd626a0](dd626a0))
* **deps:** Bump github.com/runfinch/common-tests version from v0.1.0 to
v0.1.1 ([runfinch#76](https://github.com/vsiravar/finch-public/issues/76))
([fd22d4a](fd22d4a))
* **deps:** Bump github.com/runfinch/common-tests version from v0.3.0 to
v0.3.1 ([runfinch#169](https://github.com/vsiravar/finch-public/issues/169))
([16157fe](16157fe))
* **deps:** Bump github.com/spf13/afero from 1.9.2 to 1.9.3
([#43](#43))
([bf0ad84](bf0ad84))
* **deps:** Bump github.com/spf13/afero from 1.9.3 to 1.9.4
([runfinch#241](https://github.com/vsiravar/finch-public/issues/241))
([58f26e6](58f26e6))
* **deps:** bump github.com/spf13/afero from 1.9.4 to 1.9.5
([runfinch#263](https://github.com/vsiravar/finch-public/issues/263))
([a0e277f](a0e277f))
* **deps:** Bump github.com/stretchr/testify from 1.8.0 to 1.8.1
([#44](#44))
([31c6d70](31c6d70))
* **deps:** bump github.com/stretchr/testify from 1.8.1 to 1.8.2
([runfinch#244](https://github.com/vsiravar/finch-public/issues/244))
([984af70](984af70))
* **deps:** Bump github.com/xorcare/pointer from 1.2.1 to 1.2.2
([#42](#42))
([8e83137](8e83137))
* **deps:** Bump golang.org/x/crypto from 0.1.0 to 0.3.0
([#49](#49))
([89826cf](89826cf))
* **deps:** Bump golang.org/x/crypto from 0.3.0 to 0.4.0
([runfinch#102](https://github.com/vsiravar/finch-public/issues/102))
([d2778e3](d2778e3))
* **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0
([runfinch#138](https://github.com/vsiravar/finch-public/issues/138))
([8d06eec](8d06eec))
* **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0
([runfinch#144](https://github.com/vsiravar/finch-public/issues/144))
([603419a](603419a))
* **deps:** Bump golang.org/x/crypto from 0.5.0 to 0.6.0
([runfinch#212](https://github.com/vsiravar/finch-public/issues/212))
([e1a36cf](e1a36cf))
* **deps:** bump golang.org/x/crypto from 0.6.0 to 0.7.0
([runfinch#264](https://github.com/vsiravar/finch-public/issues/264))
([ec1c07f](ec1c07f))
* **deps:** Bump golang.org/x/tools from 0.2.0 to 0.3.0
([#52](#52))
([27c8f24](27c8f24))
* **deps:** Bump golang.org/x/tools from 0.3.0 to 0.4.0
([runfinch#101](https://github.com/vsiravar/finch-public/issues/101))
([b3c4df1](b3c4df1))
* **deps:** Bump golang.org/x/tools from 0.4.0 to 0.5.0
([runfinch#139](https://github.com/vsiravar/finch-public/issues/139))
([89194dc](89194dc))
* **deps:** Bump golang.org/x/tools from 0.5.0 to 0.6.0
([runfinch#215](https://github.com/vsiravar/finch-public/issues/215))
([decf250](decf250))
* **deps:** bump golang.org/x/tools from 0.6.0 to 0.7.0
([runfinch#268](https://github.com/vsiravar/finch-public/issues/268))
([8072e39](8072e39))
* **deps:** Bump k8s.io/apimachinery from 0.25.2 to 0.25.4
([#51](#51))
([8f15779](8f15779))
* **deps:** Bump k8s.io/apimachinery from 0.25.4 to 0.26.0
([runfinch#115](https://github.com/vsiravar/finch-public/issues/115))
([e9084a4](e9084a4))
* **deps:** Bump k8s.io/apimachinery from 0.26.0 to 0.26.1
([runfinch#174](https://github.com/vsiravar/finch-public/issues/174))
([829b0bc](829b0bc))
* **deps:** bump k8s.io/apimachinery from 0.26.1 to 0.26.2
([runfinch#251](https://github.com/vsiravar/finch-public/issues/251))
([4a7268e](4a7268e))
* **deps:** bump k8s.io/apimachinery from 0.26.2 to 0.26.3
([runfinch#306](https://github.com/vsiravar/finch-public/issues/306))
([fe392cb](fe392cb))
* **deps:** Bump lima version
([runfinch#141](https://github.com/vsiravar/finch-public/issues/141))
([35da07d](35da07d))
* **deps:** Bump lima version
([runfinch#302](https://github.com/vsiravar/finch-public/issues/302))
([0269743](0269743))
* **deps:** Bump lima version
([runfinch#75](https://github.com/vsiravar/finch-public/issues/75))
([cfaa4f6](cfaa4f6))
* **deps:** Bump submodules
([runfinch#281](https://github.com/vsiravar/finch-public/issues/281))
([d4fd1f6](d4fd1f6))
* **deps:** Bump submodules
([runfinch#304](https://github.com/vsiravar/finch-public/issues/304))
([b38af9f](b38af9f))
* make finch-core a submodule instead of downloading archives
([runfinch#188](https://github.com/vsiravar/finch-public/issues/188))
([b08f588](b08f588))
* update os image versions
([runfinch#255](https://github.com/vsiravar/finch-public/issues/255))
([576765b](576765b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
Closed
@github-actions github-actions bot mentioned this pull request Dec 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhsingyuchen davidhsingyuchen davidhsingyuchen approved these changes

@ningziwen ningziwen ningziwen approved these changes

Assignees

@ningziwen ningziwen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot see finch VM status
4 participants
@niklasmtj @ningziwen @davidhsingyuchen @weikequ