-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Configure Buildkit Namespace as Env Variable #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
The containerd-rootless-setup.sh script in nerdctl takes a CONTAINERND_NAMESPACE variable when configuring the buildkit containerd worker namespace. This variable is defined here in lima so that it is passed into the containerd-rootless-setup.sh script, used by the CIDATA scripts while provisioning the VM. Signed-off-by: Olly Pomeroy <[email protected]>
ollypom
force-pushed
the
buildkit_namespace
branch
from
December 22, 2022 11:17
65c9851
to
d18c2e9
Compare
ollypom
changed the title
Configure Buildkit Namespace as Env Variable
fix: Configure Buildkit Namespace as Env Variable
Dec 22, 2022
sam-berning
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
ahsan-z-khan
pushed a commit
to ahsan-z-khan/finch
that referenced
this pull request
Jan 11, 2023
Signed-off-by: Olly Pomeroy <[email protected]> Issue #, if available: runfinch#71 *Description of changes:* Adding the [env](https://github.com/lima-vm/lima/blob/master/examples/default.yaml#L345) section to the lima vm configuration, and the defining a CONTAINERND_NAMESPACE variable. The containerd-rootless-setup.sh script in nerdctl takes a CONTAINERND_NAMESPACE variable when configuring the buildkit containerd worker namespace. This variable is defined here in lima so that it is passed into the containerd-rootless-setup.sh script, used by the CIDATA scripts while provisioning the VM. This variable is passed into CIDATA [here](https://github.com/lima-vm/lima/blob/master/pkg/cidata/cidata.TEMPLATE.d/boot/40-install-containerd.sh#L88) and is used within the containerd-rootless-setup.sh script [here](https://github.com/containerd/nerdctl/blob/main/extras/rootless/containerd-rootless-setuptool.sh#L301). *Testing done:* Built locally and verified the Variable is being consumed. ``` $ buildctl --addr=unix:///run/user/504/buildkit-finch/buildkitd.sock debug workers -v ID: 34w45gxhe8bfdr76y9jxvdo16 Platforms: linux/arm64,linux/amd64 Labels: org.mobyproject.buildkit.worker.containerd.namespace: finch org.mobyproject.buildkit.worker.containerd.uuid: a6e1dad3-4843-4ab4-b595-a912b5a3e76f org.mobyproject.buildkit.worker.executor: containerd org.mobyproject.buildkit.worker.hostname: lima-finch org.mobyproject.buildkit.worker.network: host org.mobyproject.buildkit.worker.snapshotter: overlayfs GC Policy rule#0: All: false Filters: type==source.local,type==exec.cachemount,type==source.git.checkout Keep Duration: 48h0m0s Keep Bytes: 512MB GC Policy rule#1: All: false Keep Duration: 1440h0m0s Keep Bytes: 10GB GC Policy rule#2: All: false Keep Bytes: 10GB GC Policy rule#3: All: true Keep Bytes: 10GB ``` Also tested this solves the [issue](runfinch#71): ``` $ cat Dockerfile.one FROM debian RUN apt-get update $ cat Dockerfile.two FROM mydebian RUN apt-get install curl -y $ ../finch/_output/bin/finch build -t mydebian -f Dockerfile.one . [+] Building 0.9s (6/6) FINISHED => [internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [internal] load build definition from Dockerfile.one 0.0s => => transferring dockerfile: 72B 0.0s => [internal] load metadata for docker.io/library/debian:latest 0.8s => [1/2] FROM docker.io/library/debian@sha256:c66c0e5dc607baefefda1d9e64a3b3a317e4189c540c8eac0c1a06186fe353a1 0.0s => => resolve docker.io/library/debian@sha256:c66c0e5dc607baefefda1d9e64a3b3a317e4189c540c8eac0c1a06186fe353a1 0.0s => CACHED [2/2] RUN apt-get update 0.0s => exporting to image 0.0s => => exporting layers 0.0s => => exporting manifest sha256:1ea8c95744126d9a451938b8db0fa7da10042f35e21f16a011361076975b34ba 0.0s => => exporting config sha256:bc9337720dfc88a9ee7388eb364c8b5bc7486b082577cda7d17f578fa2079c5a 0.0s => => naming to docker.io/library/mydebian:latest 0.0s => => unpacking to docker.io/library/mydebian:latest 0.0s $ ../finch/_output/bin/finch image ls REPOSITORY TAG IMAGE ID CREATED PLATFORM SIZE BLOB SIZE mydebian latest 1ea8c9574412 21 seconds ago linux/arm64 146.0 MiB 64.3 MiB $ ../finch/_output/bin/finch build -t mydebian2 -f Dockerfile.two . [+] Building 4.6s (6/6) FINISHED => [internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s => [internal] load build definition from Dockerfile.two 0.0s => => transferring dockerfile: 83B 0.0s => [internal] load metadata for docker.io/library/mydebian:latest 0.9s => CACHED [1/2] FROM docker.io/library/mydebian@sha256:1ea8c95744126d9a451938b8db0fa7da10042f35e21f16a011361076975b34ba 0.5s => => resolve docker.io/library/mydebian@sha256:1ea8c95744126d9a451938b8db0fa7da10042f35e21f16a011361076975b34ba 0.5s => [2/2] RUN apt-get install curl -y 2.7s => exporting to image 0.4s => => exporting layers 0.3s => => exporting manifest sha256:b3110f4faff6ac2334d9989c7dab34cb288d03ecb6ef6bd83c2eb02255e39e44 0.0s => => exporting config sha256:570d3e1d79d7ecc8bb54fbb9603c216b39489f036d703fc76891b566a9c358ec 0.0s => => naming to docker.io/library/mydebian2:latest 0.0s => => unpacking to docker.io/library/mydebian2:latest 0.1s ``` - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Olly Pomeroy <[email protected]>
davidhsingyuchen
pushed a commit
that referenced
this pull request
Jan 11, 2023
🤖 I have created a release *beep* *boop* --- ## [0.2.0](v0.1.1...v0.2.0) (2023-01-11) ### Features * add `finch cp` command ([#135](#135)) ([5989361](5989361)) * add config to support additional directories ([#128](#128)) ([0ceb060](0ceb060)) * Print version with Client and Server ([#108](#108)) ([7f7cdda](7f7cdda)) * saves containerd user data to a persistent disk ([#133](#133)) ([fccb4f3](fccb4f3)) ### Bug Fixes * Configure Buildkit Namespace as Env Variable ([#129](#129)) ([ffb90be](ffb90be)) * fix the misleading log when applying invalid config ([#119](#119)) ([b4f74c5](b4f74c5)) * ignore .ssh pub keys ([#109](#109)) ([0b74597](0b74597)) ### Build System or External Dependencies * **deps:** Bump github.com/lima-vm/lima from 0.13.0 to 0.14.0 ([#113](#113)) ([9b275bc](9b275bc)) * **deps:** Bump github.com/lima-vm/lima from 0.14.0 to 0.14.1 ([#120](#120)) ([9dea794](9dea794)) * **deps:** Bump github.com/lima-vm/lima from 0.14.1 to 0.14.2 ([#130](#130)) ([26b7b09](26b7b09)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 ([#114](#114)) ([934521c](934521c)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1 ([#121](#121)) ([becbc44](becbc44)) * **deps:** Bump github.com/onsi/gomega from 1.24.1 to 1.24.2 ([#122](#122)) ([d8174ff](d8174ff)) * **deps:** Bump github.com/runfinch/common-tests from 0.1.1 to 0.2.0 ([#125](#125)) ([1bac92a](1bac92a)) * **deps:** Bump golang.org/x/crypto from 0.3.0 to 0.4.0 ([#102](#102)) ([d2778e3](d2778e3)) * **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0 ([#138](#138)) ([8d06eec](8d06eec)) * **deps:** Bump golang.org/x/tools from 0.3.0 to 0.4.0 ([#101](#101)) ([b3c4df1](b3c4df1)) * **deps:** Bump golang.org/x/tools from 0.4.0 to 0.5.0 ([#139](#139)) ([89194dc](89194dc)) * **deps:** Bump k8s.io/apimachinery from 0.25.4 to 0.26.0 ([#115](#115)) ([e9084a4](e9084a4)) * **deps:** Bump lima version ([#141](#141)) ([35da07d](35da07d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vsiravar
pushed a commit
to vsiravar/finch-public
that referenced
this pull request
Mar 20, 2023
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.1...v0.5.0) (2023-03-20) ### ⚠ BREAKING CHANGES * persists nerdctl user data ([runfinch#182](https://github.com/vsiravar/finch-public/issues/182)) * changes persistent disk path to prevent collisions ### Features * add `finch cp` command ([runfinch#135](https://github.com/vsiravar/finch-public/issues/135)) ([5989361](5989361)) * add `finch vm status` command ([runfinch#83](https://github.com/vsiravar/finch-public/issues/83)) ([37d74d0](37d74d0)) * add config to support additional directories ([runfinch#128](https://github.com/vsiravar/finch-public/issues/128)) ([0ceb060](0ceb060)) * adds a --force flag to vm stop and remove ([runfinch#178](https://github.com/vsiravar/finch-public/issues/178)) ([d499a7d](d499a7d)) * Play with semver and revert ([#46](#46)) ([2299e1e](2299e1e)) * Print version with Client and Server ([runfinch#108](https://github.com/vsiravar/finch-public/issues/108)) ([7f7cdda](7f7cdda)) * saves containerd user data to a persistent disk ([runfinch#133](https://github.com/vsiravar/finch-public/issues/133)) ([fccb4f3](fccb4f3)) * Support special IP host-gateway in --add-host flag ([runfinch#216](https://github.com/vsiravar/finch-public/issues/216)) ([9a38c8e](9a38c8e)) ### Bug Fixes * changes persistent disk path to prevent collisions ([3eb66a2](3eb66a2)) * Configure Buildkit Namespace as Env Variable ([runfinch#129](https://github.com/vsiravar/finch-public/issues/129)) ([ffb90be](ffb90be)) * correctly handle local environment value pass-through ([runfinch#158](https://github.com/vsiravar/finch-public/issues/158)) ([e138f10](e138f10)) * error readable by using the right placeholder ([#39](#39)) ([8e5f38d](8e5f38d)) * fix the misleading log when applying invalid config ([runfinch#119](https://github.com/vsiravar/finch-public/issues/119)) ([b4f74c5](b4f74c5)) * ignore .ssh pub keys ([runfinch#109](https://github.com/vsiravar/finch-public/issues/109)) ([0b74597](0b74597)) * parse --add-host special ip with equal sign ([runfinch#229](https://github.com/vsiravar/finch-public/issues/229)) ([fb4b62b](fb4b62b)) * persists nerdctl user data ([runfinch#182](https://github.com/vsiravar/finch-public/issues/182)) ([59f372c](59f372c)) * persists network user data ([runfinch#211](https://github.com/vsiravar/finch-public/issues/211)) ([f6baf82](f6baf82)) * print debug logs after newline ([runfinch#273](https://github.com/vsiravar/finch-public/issues/273)) ([8faa7de](8faa7de)) * print debug logs when lima disk command fails ([runfinch#270](https://github.com/vsiravar/finch-public/issues/270)) ([78a3f50](78a3f50)) * switch from rootless containers to rootful containers ([runfinch#232](https://github.com/vsiravar/finch-public/issues/232)) ([ae43a07](ae43a07)) ### Build System or External Dependencies * clean up finch-core _output directory in clean target ([runfinch#290](https://github.com/vsiravar/finch-public/issues/290)) ([4684a95](4684a95)) * **deps:** bump finch-core to 0.1.1 ([runfinch#93](https://github.com/vsiravar/finch-public/issues/93)) ([3f3bce5](3f3bce5)) * **deps:** Bump github.com/containerd/containerd from 1.6.14 to 1.6.18 ([runfinch#223](https://github.com/vsiravar/finch-public/issues/223)) ([7480222](7480222)) * **deps:** Bump github.com/google/go-licenses from 1.5.0 to 1.6.0 ([runfinch#168](https://github.com/vsiravar/finch-public/issues/168)) ([bb5674c](bb5674c)) * **deps:** Bump github.com/lima-vm/lima from 0.12.0 to 0.13.0 ([#40](#40)) ([520cc7f](520cc7f)) * **deps:** Bump github.com/lima-vm/lima from 0.13.0 to 0.14.0 ([runfinch#113](https://github.com/vsiravar/finch-public/issues/113)) ([9b275bc](9b275bc)) * **deps:** Bump github.com/lima-vm/lima from 0.14.0 to 0.14.1 ([runfinch#120](https://github.com/vsiravar/finch-public/issues/120)) ([9dea794](9dea794)) * **deps:** Bump github.com/lima-vm/lima from 0.14.1 to 0.14.2 ([runfinch#130](https://github.com/vsiravar/finch-public/issues/130)) ([26b7b09](26b7b09)) * **deps:** bump github.com/lima-vm/lima from 0.14.2 to 0.15.0 ([runfinch#247](https://github.com/vsiravar/finch-public/issues/247)) ([007081e](007081e)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1 ([#50](#50)) ([fa108fd](fa108fd)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 ([runfinch#114](https://github.com/vsiravar/finch-public/issues/114)) ([934521c](934521c)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1 ([runfinch#121](https://github.com/vsiravar/finch-public/issues/121)) ([becbc44](becbc44)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.7.0 to 2.7.1 ([runfinch#193](https://github.com/vsiravar/finch-public/issues/193)) ([7aaa381](7aaa381)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.7.1 to 2.8.0 ([runfinch#200](https://github.com/vsiravar/finch-public/issues/200)) ([596ed33](596ed33)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.8.0 to 2.8.3 ([runfinch#233](https://github.com/vsiravar/finch-public/issues/233)) ([1185372](1185372)) * **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.3 to 2.8.4 ([runfinch#245](https://github.com/vsiravar/finch-public/issues/245)) ([5e64716](5e64716)) * **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0 ([runfinch#265](https://github.com/vsiravar/finch-public/issues/265)) ([7e2d49e](7e2d49e)) * **deps:** bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1 ([runfinch#285](https://github.com/vsiravar/finch-public/issues/285)) ([d741a03](d741a03)) * **deps:** Bump github.com/onsi/gomega from 1.24.1 to 1.24.2 ([runfinch#122](https://github.com/vsiravar/finch-public/issues/122)) ([d8174ff](d8174ff)) * **deps:** Bump github.com/onsi/gomega from 1.24.2 to 1.25.0 ([runfinch#165](https://github.com/vsiravar/finch-public/issues/165)) ([e4b9e96](e4b9e96)) * **deps:** Bump github.com/onsi/gomega from 1.25.0 to 1.26.0 ([runfinch#183](https://github.com/vsiravar/finch-public/issues/183)) ([12661b7](12661b7)) * **deps:** Bump github.com/onsi/gomega from 1.26.0 to 1.27.1 ([runfinch#234](https://github.com/vsiravar/finch-public/issues/234)) ([cd43781](cd43781)) * **deps:** bump github.com/onsi/gomega from 1.27.1 to 1.27.2 ([runfinch#246](https://github.com/vsiravar/finch-public/issues/246)) ([863c51e](863c51e)) * **deps:** Bump github.com/runfinch/common-tests from 0.1.1 to 0.2.0 ([runfinch#125](https://github.com/vsiravar/finch-public/issues/125)) ([1bac92a](1bac92a)) * **deps:** Bump github.com/runfinch/common-tests from 0.2.0 to 0.3.0 ([runfinch#151](https://github.com/vsiravar/finch-public/issues/151)) ([79df04e](79df04e)) * **deps:** Bump github.com/runfinch/common-tests from 0.5.0 to 0.6.0 ([runfinch#235](https://github.com/vsiravar/finch-public/issues/235)) ([4a33a2e](4a33a2e)) * **deps:** bump github.com/runfinch/common-tests from 0.6.1 to 0.6.2 ([runfinch#300](https://github.com/vsiravar/finch-public/issues/300)) ([dd626a0](dd626a0)) * **deps:** Bump github.com/runfinch/common-tests version from v0.1.0 to v0.1.1 ([runfinch#76](https://github.com/vsiravar/finch-public/issues/76)) ([fd22d4a](fd22d4a)) * **deps:** Bump github.com/runfinch/common-tests version from v0.3.0 to v0.3.1 ([runfinch#169](https://github.com/vsiravar/finch-public/issues/169)) ([16157fe](16157fe)) * **deps:** Bump github.com/spf13/afero from 1.9.2 to 1.9.3 ([#43](#43)) ([bf0ad84](bf0ad84)) * **deps:** Bump github.com/spf13/afero from 1.9.3 to 1.9.4 ([runfinch#241](https://github.com/vsiravar/finch-public/issues/241)) ([58f26e6](58f26e6)) * **deps:** bump github.com/spf13/afero from 1.9.4 to 1.9.5 ([runfinch#263](https://github.com/vsiravar/finch-public/issues/263)) ([a0e277f](a0e277f)) * **deps:** Bump github.com/stretchr/testify from 1.8.0 to 1.8.1 ([#44](#44)) ([31c6d70](31c6d70)) * **deps:** bump github.com/stretchr/testify from 1.8.1 to 1.8.2 ([runfinch#244](https://github.com/vsiravar/finch-public/issues/244)) ([984af70](984af70)) * **deps:** Bump github.com/xorcare/pointer from 1.2.1 to 1.2.2 ([#42](#42)) ([8e83137](8e83137)) * **deps:** Bump golang.org/x/crypto from 0.1.0 to 0.3.0 ([#49](#49)) ([89826cf](89826cf)) * **deps:** Bump golang.org/x/crypto from 0.3.0 to 0.4.0 ([runfinch#102](https://github.com/vsiravar/finch-public/issues/102)) ([d2778e3](d2778e3)) * **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0 ([runfinch#138](https://github.com/vsiravar/finch-public/issues/138)) ([8d06eec](8d06eec)) * **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0 ([runfinch#144](https://github.com/vsiravar/finch-public/issues/144)) ([603419a](603419a)) * **deps:** Bump golang.org/x/crypto from 0.5.0 to 0.6.0 ([runfinch#212](https://github.com/vsiravar/finch-public/issues/212)) ([e1a36cf](e1a36cf)) * **deps:** bump golang.org/x/crypto from 0.6.0 to 0.7.0 ([runfinch#264](https://github.com/vsiravar/finch-public/issues/264)) ([ec1c07f](ec1c07f)) * **deps:** Bump golang.org/x/tools from 0.2.0 to 0.3.0 ([#52](#52)) ([27c8f24](27c8f24)) * **deps:** Bump golang.org/x/tools from 0.3.0 to 0.4.0 ([runfinch#101](https://github.com/vsiravar/finch-public/issues/101)) ([b3c4df1](b3c4df1)) * **deps:** Bump golang.org/x/tools from 0.4.0 to 0.5.0 ([runfinch#139](https://github.com/vsiravar/finch-public/issues/139)) ([89194dc](89194dc)) * **deps:** Bump golang.org/x/tools from 0.5.0 to 0.6.0 ([runfinch#215](https://github.com/vsiravar/finch-public/issues/215)) ([decf250](decf250)) * **deps:** bump golang.org/x/tools from 0.6.0 to 0.7.0 ([runfinch#268](https://github.com/vsiravar/finch-public/issues/268)) ([8072e39](8072e39)) * **deps:** Bump k8s.io/apimachinery from 0.25.2 to 0.25.4 ([#51](#51)) ([8f15779](8f15779)) * **deps:** Bump k8s.io/apimachinery from 0.25.4 to 0.26.0 ([runfinch#115](https://github.com/vsiravar/finch-public/issues/115)) ([e9084a4](e9084a4)) * **deps:** Bump k8s.io/apimachinery from 0.26.0 to 0.26.1 ([runfinch#174](https://github.com/vsiravar/finch-public/issues/174)) ([829b0bc](829b0bc)) * **deps:** bump k8s.io/apimachinery from 0.26.1 to 0.26.2 ([runfinch#251](https://github.com/vsiravar/finch-public/issues/251)) ([4a7268e](4a7268e)) * **deps:** bump k8s.io/apimachinery from 0.26.2 to 0.26.3 ([runfinch#306](https://github.com/vsiravar/finch-public/issues/306)) ([fe392cb](fe392cb)) * **deps:** Bump lima version ([runfinch#141](https://github.com/vsiravar/finch-public/issues/141)) ([35da07d](35da07d)) * **deps:** Bump lima version ([runfinch#302](https://github.com/vsiravar/finch-public/issues/302)) ([0269743](0269743)) * **deps:** Bump lima version ([runfinch#75](https://github.com/vsiravar/finch-public/issues/75)) ([cfaa4f6](cfaa4f6)) * **deps:** Bump submodules ([runfinch#281](https://github.com/vsiravar/finch-public/issues/281)) ([d4fd1f6](d4fd1f6)) * **deps:** Bump submodules ([runfinch#304](https://github.com/vsiravar/finch-public/issues/304)) ([b38af9f](b38af9f)) * make finch-core a submodule instead of downloading archives ([runfinch#188](https://github.com/vsiravar/finch-public/issues/188)) ([b08f588](b08f588)) * update os image versions ([runfinch#255](https://github.com/vsiravar/finch-public/issues/255)) ([576765b](576765b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vsiravar
pushed a commit
to vsiravar/finch-public
that referenced
this pull request
Mar 20, 2023
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.0...v0.6.0) (2023-03-20) ### ⚠ BREAKING CHANGES * persists nerdctl user data ([runfinch#182](https://github.com/vsiravar/finch-public/issues/182)) * changes persistent disk path to prevent collisions ### Features * add `finch cp` command ([runfinch#135](https://github.com/vsiravar/finch-public/issues/135)) ([5989361](5989361)) * add `finch vm status` command ([runfinch#83](https://github.com/vsiravar/finch-public/issues/83)) ([37d74d0](37d74d0)) * add config to support additional directories ([runfinch#128](https://github.com/vsiravar/finch-public/issues/128)) ([0ceb060](0ceb060)) * adds a --force flag to vm stop and remove ([runfinch#178](https://github.com/vsiravar/finch-public/issues/178)) ([d499a7d](d499a7d)) * Play with semver and revert ([#46](#46)) ([2299e1e](2299e1e)) * Print version with Client and Server ([runfinch#108](https://github.com/vsiravar/finch-public/issues/108)) ([7f7cdda](7f7cdda)) * saves containerd user data to a persistent disk ([runfinch#133](https://github.com/vsiravar/finch-public/issues/133)) ([fccb4f3](fccb4f3)) * Support special IP host-gateway in --add-host flag ([runfinch#216](https://github.com/vsiravar/finch-public/issues/216)) ([9a38c8e](9a38c8e)) ### Bug Fixes * changes persistent disk path to prevent collisions ([3eb66a2](3eb66a2)) * Configure Buildkit Namespace as Env Variable ([runfinch#129](https://github.com/vsiravar/finch-public/issues/129)) ([ffb90be](ffb90be)) * correctly handle local environment value pass-through ([runfinch#158](https://github.com/vsiravar/finch-public/issues/158)) ([e138f10](e138f10)) * error readable by using the right placeholder ([#39](#39)) ([8e5f38d](8e5f38d)) * fix the misleading log when applying invalid config ([runfinch#119](https://github.com/vsiravar/finch-public/issues/119)) ([b4f74c5](b4f74c5)) * ignore .ssh pub keys ([runfinch#109](https://github.com/vsiravar/finch-public/issues/109)) ([0b74597](0b74597)) * parse --add-host special ip with equal sign ([runfinch#229](https://github.com/vsiravar/finch-public/issues/229)) ([fb4b62b](fb4b62b)) * persists nerdctl user data ([runfinch#182](https://github.com/vsiravar/finch-public/issues/182)) ([59f372c](59f372c)) * persists network user data ([runfinch#211](https://github.com/vsiravar/finch-public/issues/211)) ([f6baf82](f6baf82)) * print debug logs after newline ([runfinch#273](https://github.com/vsiravar/finch-public/issues/273)) ([8faa7de](8faa7de)) * print debug logs when lima disk command fails ([runfinch#270](https://github.com/vsiravar/finch-public/issues/270)) ([78a3f50](78a3f50)) * switch from rootless containers to rootful containers ([runfinch#232](https://github.com/vsiravar/finch-public/issues/232)) ([ae43a07](ae43a07)) ### Build System or External Dependencies * clean up finch-core _output directory in clean target ([runfinch#290](https://github.com/vsiravar/finch-public/issues/290)) ([4684a95](4684a95)) * **deps:** bump finch-core to 0.1.1 ([runfinch#93](https://github.com/vsiravar/finch-public/issues/93)) ([3f3bce5](3f3bce5)) * **deps:** Bump github.com/containerd/containerd from 1.6.14 to 1.6.18 ([runfinch#223](https://github.com/vsiravar/finch-public/issues/223)) ([7480222](7480222)) * **deps:** Bump github.com/google/go-licenses from 1.5.0 to 1.6.0 ([runfinch#168](https://github.com/vsiravar/finch-public/issues/168)) ([bb5674c](bb5674c)) * **deps:** Bump github.com/lima-vm/lima from 0.12.0 to 0.13.0 ([#40](#40)) ([520cc7f](520cc7f)) * **deps:** Bump github.com/lima-vm/lima from 0.13.0 to 0.14.0 ([runfinch#113](https://github.com/vsiravar/finch-public/issues/113)) ([9b275bc](9b275bc)) * **deps:** Bump github.com/lima-vm/lima from 0.14.0 to 0.14.1 ([runfinch#120](https://github.com/vsiravar/finch-public/issues/120)) ([9dea794](9dea794)) * **deps:** Bump github.com/lima-vm/lima from 0.14.1 to 0.14.2 ([runfinch#130](https://github.com/vsiravar/finch-public/issues/130)) ([26b7b09](26b7b09)) * **deps:** bump github.com/lima-vm/lima from 0.14.2 to 0.15.0 ([runfinch#247](https://github.com/vsiravar/finch-public/issues/247)) ([007081e](007081e)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1 ([#50](#50)) ([fa108fd](fa108fd)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 ([runfinch#114](https://github.com/vsiravar/finch-public/issues/114)) ([934521c](934521c)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1 ([runfinch#121](https://github.com/vsiravar/finch-public/issues/121)) ([becbc44](becbc44)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.7.0 to 2.7.1 ([runfinch#193](https://github.com/vsiravar/finch-public/issues/193)) ([7aaa381](7aaa381)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.7.1 to 2.8.0 ([runfinch#200](https://github.com/vsiravar/finch-public/issues/200)) ([596ed33](596ed33)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.8.0 to 2.8.3 ([runfinch#233](https://github.com/vsiravar/finch-public/issues/233)) ([1185372](1185372)) * **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.3 to 2.8.4 ([runfinch#245](https://github.com/vsiravar/finch-public/issues/245)) ([5e64716](5e64716)) * **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0 ([runfinch#265](https://github.com/vsiravar/finch-public/issues/265)) ([7e2d49e](7e2d49e)) * **deps:** bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1 ([runfinch#285](https://github.com/vsiravar/finch-public/issues/285)) ([d741a03](d741a03)) * **deps:** Bump github.com/onsi/gomega from 1.24.1 to 1.24.2 ([runfinch#122](https://github.com/vsiravar/finch-public/issues/122)) ([d8174ff](d8174ff)) * **deps:** Bump github.com/onsi/gomega from 1.24.2 to 1.25.0 ([runfinch#165](https://github.com/vsiravar/finch-public/issues/165)) ([e4b9e96](e4b9e96)) * **deps:** Bump github.com/onsi/gomega from 1.25.0 to 1.26.0 ([runfinch#183](https://github.com/vsiravar/finch-public/issues/183)) ([12661b7](12661b7)) * **deps:** Bump github.com/onsi/gomega from 1.26.0 to 1.27.1 ([runfinch#234](https://github.com/vsiravar/finch-public/issues/234)) ([cd43781](cd43781)) * **deps:** bump github.com/onsi/gomega from 1.27.1 to 1.27.2 ([runfinch#246](https://github.com/vsiravar/finch-public/issues/246)) ([863c51e](863c51e)) * **deps:** Bump github.com/runfinch/common-tests from 0.1.1 to 0.2.0 ([runfinch#125](https://github.com/vsiravar/finch-public/issues/125)) ([1bac92a](1bac92a)) * **deps:** Bump github.com/runfinch/common-tests from 0.2.0 to 0.3.0 ([runfinch#151](https://github.com/vsiravar/finch-public/issues/151)) ([79df04e](79df04e)) * **deps:** Bump github.com/runfinch/common-tests from 0.5.0 to 0.6.0 ([runfinch#235](https://github.com/vsiravar/finch-public/issues/235)) ([4a33a2e](4a33a2e)) * **deps:** bump github.com/runfinch/common-tests from 0.6.1 to 0.6.2 ([runfinch#300](https://github.com/vsiravar/finch-public/issues/300)) ([dd626a0](dd626a0)) * **deps:** Bump github.com/runfinch/common-tests version from v0.1.0 to v0.1.1 ([runfinch#76](https://github.com/vsiravar/finch-public/issues/76)) ([fd22d4a](fd22d4a)) * **deps:** Bump github.com/runfinch/common-tests version from v0.3.0 to v0.3.1 ([runfinch#169](https://github.com/vsiravar/finch-public/issues/169)) ([16157fe](16157fe)) * **deps:** Bump github.com/spf13/afero from 1.9.2 to 1.9.3 ([#43](#43)) ([bf0ad84](bf0ad84)) * **deps:** Bump github.com/spf13/afero from 1.9.3 to 1.9.4 ([runfinch#241](https://github.com/vsiravar/finch-public/issues/241)) ([58f26e6](58f26e6)) * **deps:** bump github.com/spf13/afero from 1.9.4 to 1.9.5 ([runfinch#263](https://github.com/vsiravar/finch-public/issues/263)) ([a0e277f](a0e277f)) * **deps:** Bump github.com/stretchr/testify from 1.8.0 to 1.8.1 ([#44](#44)) ([31c6d70](31c6d70)) * **deps:** bump github.com/stretchr/testify from 1.8.1 to 1.8.2 ([runfinch#244](https://github.com/vsiravar/finch-public/issues/244)) ([984af70](984af70)) * **deps:** Bump github.com/xorcare/pointer from 1.2.1 to 1.2.2 ([#42](#42)) ([8e83137](8e83137)) * **deps:** Bump golang.org/x/crypto from 0.1.0 to 0.3.0 ([#49](#49)) ([89826cf](89826cf)) * **deps:** Bump golang.org/x/crypto from 0.3.0 to 0.4.0 ([runfinch#102](https://github.com/vsiravar/finch-public/issues/102)) ([d2778e3](d2778e3)) * **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0 ([runfinch#138](https://github.com/vsiravar/finch-public/issues/138)) ([8d06eec](8d06eec)) * **deps:** Bump golang.org/x/crypto from 0.4.0 to 0.5.0 ([runfinch#144](https://github.com/vsiravar/finch-public/issues/144)) ([603419a](603419a)) * **deps:** Bump golang.org/x/crypto from 0.5.0 to 0.6.0 ([runfinch#212](https://github.com/vsiravar/finch-public/issues/212)) ([e1a36cf](e1a36cf)) * **deps:** bump golang.org/x/crypto from 0.6.0 to 0.7.0 ([runfinch#264](https://github.com/vsiravar/finch-public/issues/264)) ([ec1c07f](ec1c07f)) * **deps:** Bump golang.org/x/tools from 0.2.0 to 0.3.0 ([#52](#52)) ([27c8f24](27c8f24)) * **deps:** Bump golang.org/x/tools from 0.3.0 to 0.4.0 ([runfinch#101](https://github.com/vsiravar/finch-public/issues/101)) ([b3c4df1](b3c4df1)) * **deps:** Bump golang.org/x/tools from 0.4.0 to 0.5.0 ([runfinch#139](https://github.com/vsiravar/finch-public/issues/139)) ([89194dc](89194dc)) * **deps:** Bump golang.org/x/tools from 0.5.0 to 0.6.0 ([runfinch#215](https://github.com/vsiravar/finch-public/issues/215)) ([decf250](decf250)) * **deps:** bump golang.org/x/tools from 0.6.0 to 0.7.0 ([runfinch#268](https://github.com/vsiravar/finch-public/issues/268)) ([8072e39](8072e39)) * **deps:** Bump k8s.io/apimachinery from 0.25.2 to 0.25.4 ([#51](#51)) ([8f15779](8f15779)) * **deps:** Bump k8s.io/apimachinery from 0.25.4 to 0.26.0 ([runfinch#115](https://github.com/vsiravar/finch-public/issues/115)) ([e9084a4](e9084a4)) * **deps:** Bump k8s.io/apimachinery from 0.26.0 to 0.26.1 ([runfinch#174](https://github.com/vsiravar/finch-public/issues/174)) ([829b0bc](829b0bc)) * **deps:** bump k8s.io/apimachinery from 0.26.1 to 0.26.2 ([runfinch#251](https://github.com/vsiravar/finch-public/issues/251)) ([4a7268e](4a7268e)) * **deps:** bump k8s.io/apimachinery from 0.26.2 to 0.26.3 ([runfinch#306](https://github.com/vsiravar/finch-public/issues/306)) ([fe392cb](fe392cb)) * **deps:** Bump lima version ([runfinch#141](https://github.com/vsiravar/finch-public/issues/141)) ([35da07d](35da07d)) * **deps:** Bump lima version ([runfinch#302](https://github.com/vsiravar/finch-public/issues/302)) ([0269743](0269743)) * **deps:** Bump lima version ([runfinch#75](https://github.com/vsiravar/finch-public/issues/75)) ([cfaa4f6](cfaa4f6)) * **deps:** Bump submodules ([runfinch#281](https://github.com/vsiravar/finch-public/issues/281)) ([d4fd1f6](d4fd1f6)) * **deps:** Bump submodules ([runfinch#304](https://github.com/vsiravar/finch-public/issues/304)) ([b38af9f](b38af9f)) * make finch-core a submodule instead of downloading archives ([runfinch#188](https://github.com/vsiravar/finch-public/issues/188)) ([b08f588](b08f588)) * update os image versions ([runfinch#255](https://github.com/vsiravar/finch-public/issues/255)) ([576765b](576765b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olly Pomeroy [email protected]
Issue #, if available: #71
Description of changes:
Adding the env section to the lima vm configuration, and the defining a CONTAINERND_NAMESPACE variable.
The containerd-rootless-setup.sh script in nerdctl takes a CONTAINERND_NAMESPACE variable when configuring the buildkit containerd worker namespace. This variable is defined here in lima so that it is passed into the containerd-rootless-setup.sh script, used by the CIDATA scripts while provisioning the VM.
This variable is passed into CIDATA here and is used within the containerd-rootless-setup.sh script here.
Testing done:
Built locally and verified the Variable is being consumed.
Also tested this solves the issue:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.