Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add local-core Makefile target #351

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Conversation

pendo324
Copy link
Member

Issue #, if available:

Description of changes:

  • adds new Makefile target that uses the locally compiled submodule version of Lima instead of the version from the lima-and-qemu remote archive. This allows more easy testing of local submodule changes before building a new lima-and-qemu archive.

Testing done:

  • local testing

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324 pendo324 added the enhancement New feature or request label Apr 10, 2023
@pendo324 pendo324 requested a review from ningziwen April 10, 2023 18:04
@pendo324 pendo324 self-assigned this Apr 10, 2023
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Justin Alvarez <[email protected]>
@pendo324 pendo324 requested a review from ningziwen April 10, 2023 18:08
@ningziwen
Copy link
Member

This can unblock local tests but the CI still uses make unless we change it to make all-local.

@pendo324
Copy link
Member Author

This can unblock local tests but the CI still uses make unless we change it to make all-local.

My motivation was to make it possible to test locally. CI should use what is actually used by the release imo. Maybe we can add more ci targets in the future and have some use the all-local target and some use the lima-and-qemu target.

@pendo324
Copy link
Member Author

Compose test failed due to known issue. Merging.

@pendo324 pendo324 merged commit f86c56f into runfinch:main Apr 10, 2023
mharwani pushed a commit that referenced this pull request Apr 20, 2023
🤖 I have created a release *beep* *boop*
---


## [0.6.0](v0.5.0...v0.6.0)
(2023-04-20)


### Features

* add experimental support for Cosign signing and verification
([#296](#296))
([84c2634](84c2634))


### Bug Fixes

* always force stop when using Virtualization.framework
([#350](#350))
([c521f1f](c521f1f))
* explicitly set permissions for socket_vmnet dependencies
([#363](#363))
([0801b88](0801b88))


### Build System or External Dependencies

* add local-core Makefile target
([#351](#351))
([f86c56f](f86c56f))
* **deps:** Bump github.com/docker/docker from 23.0.1+incompatible to
23.0.2+incompatible
([#320](#320))
([ee3df9a](ee3df9a))
* **deps:** Bump github.com/docker/docker from 23.0.2+incompatible to
23.0.3+incompatible
([#343](#343))
([6cfbb9f](6cfbb9f))
* **deps:** Bump github.com/lima-vm/lima from 0.15.0 to 0.15.1
([#365](#365))
([1d3ee98](1d3ee98))
* **deps:** Bump github.com/onsi/gomega from 1.27.5 to 1.27.6
([#331](#331))
([fe388a3](fe388a3))
* **deps:** Bump github.com/runfinch/common-tests from 0.6.4 to 0.6.5
([#357](#357))
([dc84864](dc84864))
* **deps:** Bump github.com/runfinch/common-tests version from v0.6.2 to
v0.6.3 ([#328](#328))
([1c44b3e](1c44b3e))
* **deps:** Bump github.com/spf13/cobra from 1.6.1 to 1.7.0
([#341](#341))
([6a77f72](6a77f72))
* **deps:** Bump golang.org/x/crypto from 0.7.0 to 0.8.0
([#349](#349))
([82b27c9](82b27c9))
* **deps:** Bump golang.org/x/tools from 0.7.0 to 0.8.0
([#348](#348))
([aaca2c9](aaca2c9))
* **deps:** Bump k8s.io/apimachinery from 0.26.3 to 0.27.1
([#366](#366))
([b93d3a8](b93d3a8))
* **deps:** Bump lima version
([#354](#354))
([c721ee6](c721ee6))
* **deps:** Bump lima version
([#362](#362))
([5e03a4d](5e03a4d))
* **deps:** Bump lima version
([#368](#368))
([8e4dfe4](8e4dfe4))
* **deps:** Bump submodules
([#340](#340))
([daed9e2](daed9e2))
* **deps:** Bump submodules
([#371](#371))
([19fc0c5](19fc0c5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants