fix: always force stop when using Virtualization.framework #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
ningziwen
approved these changes
Apr 12, 2023
pendo324
added a commit
to pendo324/finch
that referenced
this pull request
Apr 17, 2023
…unfinch#350)" This reverts commit c521f1f.
1 task
pendo324
added a commit
to pendo324/finch
that referenced
this pull request
Apr 17, 2023
…unfinch#350)" This reverts commit c521f1f. Signed-off-by: Justin Alvarez <[email protected]>
mharwani
pushed a commit
that referenced
this pull request
Apr 20, 2023
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.0...v0.6.0) (2023-04-20) ### Features * add experimental support for Cosign signing and verification ([#296](#296)) ([84c2634](84c2634)) ### Bug Fixes * always force stop when using Virtualization.framework ([#350](#350)) ([c521f1f](c521f1f)) * explicitly set permissions for socket_vmnet dependencies ([#363](#363)) ([0801b88](0801b88)) ### Build System or External Dependencies * add local-core Makefile target ([#351](#351)) ([f86c56f](f86c56f)) * **deps:** Bump github.com/docker/docker from 23.0.1+incompatible to 23.0.2+incompatible ([#320](#320)) ([ee3df9a](ee3df9a)) * **deps:** Bump github.com/docker/docker from 23.0.2+incompatible to 23.0.3+incompatible ([#343](#343)) ([6cfbb9f](6cfbb9f)) * **deps:** Bump github.com/lima-vm/lima from 0.15.0 to 0.15.1 ([#365](#365)) ([1d3ee98](1d3ee98)) * **deps:** Bump github.com/onsi/gomega from 1.27.5 to 1.27.6 ([#331](#331)) ([fe388a3](fe388a3)) * **deps:** Bump github.com/runfinch/common-tests from 0.6.4 to 0.6.5 ([#357](#357)) ([dc84864](dc84864)) * **deps:** Bump github.com/runfinch/common-tests version from v0.6.2 to v0.6.3 ([#328](#328)) ([1c44b3e](1c44b3e)) * **deps:** Bump github.com/spf13/cobra from 1.6.1 to 1.7.0 ([#341](#341)) ([6a77f72](6a77f72)) * **deps:** Bump golang.org/x/crypto from 0.7.0 to 0.8.0 ([#349](#349)) ([82b27c9](82b27c9)) * **deps:** Bump golang.org/x/tools from 0.7.0 to 0.8.0 ([#348](#348)) ([aaca2c9](aaca2c9)) * **deps:** Bump k8s.io/apimachinery from 0.26.3 to 0.27.1 ([#366](#366)) ([b93d3a8](b93d3a8)) * **deps:** Bump lima version ([#354](#354)) ([c721ee6](c721ee6)) * **deps:** Bump lima version ([#362](#362)) ([5e03a4d](5e03a4d)) * **deps:** Bump lima version ([#368](#368)) ([8e4dfe4](8e4dfe4)) * **deps:** Bump submodules ([#340](#340)) ([daed9e2](daed9e2)) * **deps:** Bump submodules ([#371](#371)) ([19fc0c5](19fc0c5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pendo324
added a commit
that referenced
this pull request
Feb 14, 2024
This reverts commit c521f1f. Issue #, if available: After #368 is merged, the change to always force stop the VM is no longer necessary, since the upstream issue mentioned in #350 has been fixed in the new version of Lima. *Description of changes:* Undo the changes in #350 *Testing done:* - local testing - unit tests - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Refs: c521f1f --------- Signed-off-by: Justin Alvarez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
panic: runtime/cgo: misuse of an invalid Handle(Code-Hex/vz/v3.changeStateOnObserver) lima-vm/lima#1381 (needs more testing)Testing done:
local testing
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.