chore: update Fedora image #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahsan Khan <[email protected]>
|
Closing / reopening to re-trigger workflows. |
|
Looks like the latest core release broke something with socket_vmnet, related to runfinch/finch-core#38, I'll try to fix it and then retrigger everything. |
1 task
pendo324
added a commit
that referenced
this pull request
Jan 26, 2023
) Signed-off-by: Justin Alvarez <[email protected]> Issue #, if available: Supersedes #185, resolves #21 *Description of changes:* - make finch-core a submodule instead of downloading the release tarball - removes the extra step of uploading / downloading tar files from the internet at build time - makes it easier/possible to reference the submodules of finch-core directly *Testing done:* - local build and e2e tests - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]>
|
Closing as its no longer needed after merging #185. Thanks for getting the ball rolling on this, @ahsan-z-khan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahsan Khan [email protected]
Issue #, if available:
This PR depends on merging of runfinch/finch-core#41
Description of changes:
Updated the latest fedora image and hash.
Testing done:
Tested locally with
make test-e2eLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.