Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Fedora image #41

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

ahsan-z-khan
Copy link
Member

Signed-off-by: Ahsan Khan [email protected]

Issue #, if available:

Description of changes:
Updated Fedora OS image to the latest version to address security vulnerabilities.

Testing done:
make test-e2e

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Ahsan Khan <[email protected]>
@ahsan-z-khan ahsan-z-khan changed the title chore: update Fedora image chore!: update Fedora image Jan 25, 2023
@ahsan-z-khan ahsan-z-khan requested a review from pendo324 January 25, 2023 19:08
@pendo324
Copy link
Member

LGTM, thanks

@ningziwen
Copy link
Member

Why is this a breaking change? Any existing E2E tests failed?

@pendo324
Copy link
Member

Good point @ningziwen, it shouldn't be a breaking change. @ahsan-z-khan, please change the title to remove the ! before merging.

@ahsan-z-khan ahsan-z-khan changed the title chore!: update Fedora image chore: update Fedora image Jan 25, 2023
@ahsan-z-khan
Copy link
Member Author

finch cp tests failing for me locally. Don't merge it yet. I'll update on it. Testing manually on a container

@pendo324
Copy link
Member

finch cp tests failing for me locally. Don't merge it yet. I'll update on it. Testing manually on a container

fwiw, all the tests passed on my system (Intel 12.6.2)

@ahsan-z-khan
Copy link
Member Author

okay

finch cp tests failing for me locally. Don't merge it yet. I'll update on it. Testing manually on a container

fwiw, all the tests passed on my system (Intel 12.6.2)

Okay let's merge then? Might be an issue with my local setup.

@pendo324 pendo324 merged commit 41bf2f0 into runfinch:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants