Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split e2e tests into 2 packages, vm and container #150

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

davidhsingyuchen
Copy link
Contributor

@davidhsingyuchen davidhsingyuchen commented Jan 12, 2023

Summary

PR fixes #142 (comment) by splitting container tests and vm tests into different binaries (i.e., different packages) to make sure that the former is run before the latter.

The package-level comment of the e2e package provides more details, so reading it first may make reviewing this PR easier.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@davidhsingyuchen davidhsingyuchen force-pushed the bump-ginkgo branch 6 times, most recently from c2f966f to 70e97d7 Compare January 12, 2023 19:07
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split makes a lot of sense after reading the package level comments, you did a great job citing the Ginkgo docs. But I wonder if vm is the best name for the package, since it also contains test for config and the version command. Does something like container and app make sense? Or maybe container and cli or common and cli? Definitely open to discussion here

@davidhsingyuchen
Copy link
Contributor Author

davidhsingyuchen commented Jan 12, 2023

@pendo324

The split makes a lot of sense after reading the package level comments, you did a great job citing the Ginkgo docs.

Thanks. Updated the PR description to recommend reviewers to read the package-level comments first.

But I wonder if vm is the best name for the package, since it also contains test for config and the version command. Does something like container and app make sense? Or maybe container and cli or common and cli? Definitely open to discussion here

I named it vm because the tests there are more concerned about the VM itself instead of the container development functionalities it provides. Open to other names though.

Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with merging it with these names, we can change them later if we come up with something better

@davidhsingyuchen davidhsingyuchen merged commit 8cacb1f into runfinch:main Jan 12, 2023
@davidhsingyuchen davidhsingyuchen deleted the bump-ginkgo branch January 12, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants