Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Bump github.com/onsi/ginkgo/v2 from 2.6.1 to 2.7.0 #142

Closed
wants to merge 1 commit into from
Closed

build(deps): Bump github.com/onsi/ginkgo/v2 from 2.6.1 to 2.7.0 #142

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 10, 2023 •
edited
Loading

Bumps github.com/onsi/ginkgo/v2 from 2.6.1 to 2.7.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.7.0

2.7.0

Features

  • Introduce ContinueOnFailure for Ordered containers [e0123ca] - Ordered containers that are also decorated with ContinueOnFailure will not stop running specs after the first spec fails.
  • Support for bootstrap commands to use custom data for templates (#1110) [7a2b242]
  • Support for labels and pending decorator in ginkgo outline output (#1113) [e6e3b98]
  • Color aliases for custom color support (#1101) [49fab7a]

Fixes

  • correctly ensure deterministic spec order, even if specs are generated by iterating over a map [89dda20]
  • Fix a bug where timedout specs were not correctly treated as failures when determining whether or not to run AfterAlls in an Ordered container.
  • Ensure go test coverprofile outputs to the expected location (#1105) [b0bd77b]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.7.0

Features

  • Introduce ContinueOnFailure for Ordered containers [e0123ca] - Ordered containers that are also decorated with ContinueOnFailure will not stop running specs after the first spec fails.
  • Support for bootstrap commands to use custom data for templates (#1110) [7a2b242]
  • Support for labels and pending decorator in ginkgo outline output (#1113) [e6e3b98]
  • Color aliases for custom color support (#1101) [49fab7a]

Fixes

  • correctly ensure deterministic spec order, even if specs are generated by iterating over a map [89dda20]
  • Fix a bug where timedout specs were not correctly treated as failures when determining whether or not to run AfterAlls in an Ordered container.
  • Ensure go test coverprofile outputs to the expected location (#1105) [b0bd77b]
Commits
  • 310a73f v2.7.0
  • e0123ca Introduce ContinueOnFailure for Ordered containers
  • 89dda20 correctly ensure deterministic spec order, even if specs are generated by ite...
  • 7a2b242 Support for bootstrap commands to use custom data for templates (#1110)
  • 62fff95 ensure deterministic order even if specs are generated by iterating over a map
  • e6e3b98 Support for labels and pending decorator in ginkgo outline output (#1113)
  • b0bd77b Ensure go test coverprofile outputs to the expected location (#1105)
  • 49fab7a Color aliases for custom color support (#1101)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 10, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 11, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
build(deps): Bump github.com/onsi/ginkgo/v2 from 2.6.1 to 2.7.0
1626c07 
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.6.1 to 2.7.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.6.1...v2.7.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.7.0 branch from e6cb50e to 1626c07 Compare January 11, 2023 03:24
@davidhsingyuchen
Copy link
Contributor

Likely the tests are not failing due to flakiness. Need some investigation.

@davidhsingyuchen
Copy link
Contributor

davidhsingyuchen commented Jan 12, 2023 •
edited
Loading

The tests are failing because they are not run in the order they are defined, while they must be:

When running tests in serial sequence and using the local registry, testVirtualMachine needs to run after generic tests finished since it will remove the VM instance thus removing the local registry.

To be specific, testAdditionalDisk is not the first test that's defined, but it's the first one that's run for all 4 e2e jobs:

Why? By default, Ginkgo does not guarantee the order in which specs run, which means that we have been depending on an implementation detail, and I guess they changed the order from definition order to something else.

@davidhsingyuchen davidhsingyuchen mentioned this pull request Jan 12, 2023
Merged
@ahsan-z-khan
Copy link
Member

ahsan-z-khan commented Jan 12, 2023 •
edited
Loading

This might be issue for the intermittent failures - https://github.com/onsi/ginkgo/commit/62fff9539c30ca989d2fe6eeb6a23b0a86dea94b. Seems like they have changed the ordering.

davidhsingyuchen added a commit that referenced this pull request Jan 12, 2023
@davidhsingyuchen
chore: split e2e tests into 2 packages, vm and container (#150)
8cacb1f 
## Summary

PR fixes
#142 (comment) by
splitting container tests and vm tests into different binaries (i.e.,
different packages) to make sure that the former is run before the
latter.

The package-level comment of the `e2e` package provides more details, so
reading it first may make reviewing this PR easier.

## License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Hsing-Yu (David) Chen <[email protected]>
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.7.0 branch January 12, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhsingyuchen davidhsingyuchen davidhsingyuchen left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhsingyuchen @ahsan-z-khan