Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run --pid=host sometimes fails in CI #31

Closed
davidhsingyuchen opened this issue Nov 23, 2022 · 0 comments
Closed

run --pid=host sometimes fails in CI #31

davidhsingyuchen opened this issue Nov 23, 2022 · 0 comments
Assignees
@davidhsingyuchen @AnqiPang
Labels
bug Something isn't working

Comments

@davidhsingyuchen
Copy link
Contributor

davidhsingyuchen commented Nov 23, 2022 •
edited
Loading

Describe the bug

run --pid-host sometimes fails in CI.

Steps to reproduce

It's flaky. Sometimes it passes, while sometimes it fails.

Expected behavior

It should always pass.

Screenshots or logs
@davidhsingyuchen davidhsingyuchen added the bug Something isn't working label Nov 23, 2022
@AnqiPang AnqiPang self-assigned this Nov 28, 2022
@AnqiPang AnqiPang mentioned this issue Nov 29, 2022
Merged
1 task
AnqiPang added a commit to runfinch/common-tests that referenced this issue Nov 30, 2022
@AnqiPang
fix: --pid=host tests (#8)
77342d8 
Issue #, if available:

*Description of changes:*
Fix the [GitHub issue](runfinch/finch#31) that
--pid=host test sometimes fails.
Add a spec for --test=container:<container>.
*Testing done:*
Tests passed locally.


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Anqi Pang <[email protected]>
@pendo324 pendo324 moved this to Next version in Engineering Roadmap Nov 30, 2022
@ningziwen ningziwen removed the status in Engineering Roadmap Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidhsingyuchen davidhsingyuchen

@AnqiPang AnqiPang

Labels
bug Something isn't working
Projects
Engineering Roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ChandruShetty @davidhsingyuchen @AnqiPang @sam-berning