fix: --pid=host tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anqi Pang <[email protected]>
AnqiPang
force-pushed
the
anqipang/fix-pid-test
branch
from
f53e2aa to
cb5b13e
Compare
There was a problem hiding this comment.
- It seems that
topis replaced withinspect. Could you elaborate more re. why that solves the issue? - nit: Next time maybe we can add the test case (i.e.,
--pid=container:<container>) in a follow-up PR to keep each PR focused (i.e., this PR only fixes the bug, nothing more).
| @@ -205,11 +205,16 @@ func Run(o *option.Option) { | |||
| }) | |||
|
|
|||
| ginkgo.It("should share PID namespace with host with --pid=host", func() { | |||
There was a problem hiding this comment.
Maybe that's (partly) addressed by #8 (comment)?
Signed-off-by: Anqi Pang <[email protected]>
davidhsingyuchen
approved these changes
Nov 29, 2022
AnqiPang
pushed a commit
that referenced
this pull request
Nov 30, 2022
🤖 I have created a release *beep* *boop* --- ## [0.1.1](v0.1.0...v0.1.1) (2022-11-30) ### Bug Fixes * --pid=host tests ([#8](#8)) ([77342d8](77342d8)) ### Build System or External Dependencies * **deps:** bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1 ([#3](#3)) ([abf1f07](abf1f07)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix the GitHub issue that --pid=host test sometimes fails.
Add a spec for --test=container:.
Testing done:
Tests passed locally.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.