Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: google_logging_enabled variable now correctly passed to instance template #151

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: google_logging_enabled variable now correctly passed to instance template #151

merged 1 commit into from
Apr 19, 2024

Conversation

d-costa
Copy link
Collaborator

@d-costa d-costa commented Apr 19, 2024

what

  • google_logging_enabled variable now correctly passed to instance template

why

  • google_monitoring_enabled was used instead of google_logging_enabled to set the instance template google-logging-enabled

references

@d-costa d-costa requested a review from a team as a code owner April 19, 2024 22:58
@d-costa d-costa merged commit e519978 into main Apr 19, 2024
2 checks passed
@d-costa d-costa deleted the d-costa/fix-logging branch April 19, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calexandre calexandre calexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable "google_logging_enabled" is declared but not used
2 participants
@d-costa @calexandre