Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable "google_logging_enabled" is declared but not used #129

Closed
d-costa opened this issue Nov 27, 2023 · 1 comment · Fixed by #151
Closed

Variable "google_logging_enabled" is declared but not used #129

d-costa opened this issue Nov 27, 2023 · 1 comment · Fixed by #151

Comments

@d-costa
Copy link
Collaborator

d-costa commented Nov 27, 2023

First of all, thank you for developing this module, it is extremely useful.

I noticed the variable google_logging_enabled is not used, and the monitoring variable is used to set the logging metadata on the compute instance. Is this behavior intended?

https://github.com/bschaatsbergen/terraform-gce-atlantis/blob/263a41ab20befe5c9a8f7b584ae6e2a6e69c4167/main.tf#L132-L133

PS: I don't mind raising a PR if this is indeed not intended

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Nov 30, 2023

Thanks for raising this issue @d-costa :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants