Add ability to set source in status checks #492

lkysow · 2019-02-25T22:13:56Z

No description provided.

This is the same interface as vcs.Client so no need to have both.

This is needed so we can set different commit statuses for plan and apply phases. Also, append os env variables to git commands during cloning. This fixed a bug when running tests where I got an error because git couldn't expand '~' from its git config to my home directory because the HOME env var wasn't set.

codecov · 2019-02-25T22:15:52Z

Codecov Report

Merging #492 into master will increase coverage by 0.01%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   70.65%   70.67%   +0.01%     
==========================================
  Files          63       63              
  Lines        4291     4290       -1     
==========================================
  Hits         3032     3032              
+ Misses       1031     1030       -1     
  Partials      228      228

Impacted Files	Coverage Δ
server/locks_controller.go	`87.14% <ø> (ø)`	⬆️
server/events_controller.go	`53.19% <ø> (ø)`	⬆️
server/events/pull_closed_executor.go	`89.74% <ø> (ø)`	⬆️
server/events/project_command_builder.go	`84.68% <ø> (ø)`	⬆️
server/events/command_runner.go	`65.46% <ø> (ø)`	⬆️
server/events/vcs/gitlab_client.go	`25.86% <0%> (+0.22%)`	⬆️
server/events/vcs/bitbucketserver/client.go	`33.72% <0%> (ø)`	⬆️
server/events/vcs/not_configured_vcs_client.go	`0% <0%> (ø)`	⬆️
server/events/vcs/bitbucketcloud/client.go	`40.16% <0%> (ø)`	⬆️
server/events/vcs/github_client.go	`73.14% <100%> (-0.25%)`	⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9464b...b749a32. Read the comment docs.

osterman · 2019-02-28T09:45:54Z

@lkysow is this related to #446?

lkysow · 2019-02-28T14:18:40Z

Maybe... 😄

lkysow · 2019-02-28T16:04:42Z

Closing for #503

lkysow added 2 commits February 25, 2019 16:51

Remove duplicate vcs proxy interface

1997e11

This is the same interface as vcs.Client so no need to have both.

lkysow closed this Feb 28, 2019

lkysow deleted the status-check-src branch February 28, 2019 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to set source in status checks #492

Add ability to set source in status checks #492

lkysow commented Feb 25, 2019

codecov bot commented Feb 25, 2019 •

edited

Loading

osterman commented Feb 28, 2019

lkysow commented Feb 28, 2019

lkysow commented Feb 28, 2019

Add ability to set source in status checks #492

Add ability to set source in status checks #492

Conversation

lkysow commented Feb 25, 2019

codecov bot commented Feb 25, 2019 • edited Loading

Codecov Report

osterman commented Feb 28, 2019

lkysow commented Feb 28, 2019

lkysow commented Feb 28, 2019

codecov bot commented Feb 25, 2019 •

edited

Loading