fix(atlantis-image): add missing atlantis user in Debian image #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
force-pushed
the
wyardley/debian-user
branch
2 times, most recently
from
f99f2a1 to
340877d
Compare
wyardley
commented
Apr 11, 2023
| @@ -180,6 +180,13 @@ CMD ["server"] | |||
| # Stage 2 - Debian | |||
| FROM debian:${DEBIAN_TAG} AS debian | |||
|
|
|||
| # Add atlantis user to Debian as well | |||
| RUN useradd --create-home --user-group --shell /bin/bash atlantis && \ | |||
There was a problem hiding this comment.
happy to make this have a stable uid / gid if folks think it's useful here.
There was a problem hiding this comment.
I think in the alpine this was 1001 I believe
There was a problem hiding this comment.
I could not find any reference on that so I think is ok
There was a problem hiding this comment.
Yeah, this is copied from the old Debian dockerfile, and I didn’t see the Alpine one setting it either.
There was a problem hiding this comment.
fwiw, I believe (older) alpine images were uid=100, gid=1000
# cat /etc/passwd | grep atlantis
atlantis:x:100:1000:Linux User,,,:/home/atlantis:/sbin/nologin
Current debian image uid=1000 (gid=1000 unchanged)
# cat /etc/passwd | grep atlantis
atlantis:x:1000:1000::/home/atlantis:/bin/bash
bmbferreira
previously approved these changes
Apr 11, 2023
nitrocode
changed the title
jamengual
approved these changes
Apr 11, 2023
GenPage
approved these changes
Apr 11, 2023
GenPage
force-pushed
the
wyardley/debian-user
branch
from
340877d to
2160d50
Compare
It appears that when runatlantis#3001 combined the Dockerfiles, the bit that adds the `atlantis` user was not added to the Debian build stage Also correct some trailing spaces and missing EOL in `docker-compose.yml`
GenPage
force-pushed
the
wyardley/debian-user
branch
from
2160d50 to
a3b8848
Compare
|
Merging this. The docker build shouldn't push to the repo and thus the failure. Will fix that along with some other issues missed in #3001 |
nitrocode
pushed a commit
that referenced
this pull request
May 5, 2023
It appears that when #3001 combined the Dockerfiles, the bit that adds the `atlantis` user was not added to the Debian build stage Also correct some trailing spaces and missing EOL in `docker-compose.yml`
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
It appears that when runatlantis#3001 combined the Dockerfiles, the bit that adds the `atlantis` user was not added to the Debian build stage Also correct some trailing spaces and missing EOL in `docker-compose.yml`
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
It appears that when runatlantis#3001 combined the Dockerfiles, the bit that adds the `atlantis` user was not added to the Debian build stage Also correct some trailing spaces and missing EOL in `docker-compose.yml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
atlantisuser was not added to the Debian build stagedocker-compose.ymltests
references
Closes #3318