[fix] ignore commit status for apply jobs (#2135) #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skeen
reviewed
Apr 26, 2022
chore: simplify ignored statuses logic Co-authored-by: Emil 'Skeen' Madsen <[email protected]>
|
Hi @jamengual, could this fix be added to the v0.19.3-pre ? |
|
@michelmzs can you add some tests? |
jamengual
added
bug
|
Test added @jamengual |
|
@michelmzs we will add this to the next |
|
Thank you, glad to contribute. |
|
@michelmzs can you look into #2304 please? |
@jamengual the fix is ready to review #2312 |
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…ntis#2137) * fix: update commit status check logic to match the commit status name * Update server/events/vcs/gitlab_client.go chore: simplify ignored statuses logic Co-authored-by: Emil 'Skeen' Madsen <[email protected]> * feat(gitlab_client_test): add PullIsMergeable test case Co-authored-by: Emil 'Skeen' Madsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue #2135.
Behavior started in version 0.18.0, apply jobs are not being ignored during the apply requirements validation.