You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.
Overview of the Issue
Atlantis cannot apply when a failure occurs due to lack of apply_requirements, even if the requirements have been met after.
In this case, the mergeable requirement always fails because one of the apply jobs in the pipeline failed (apply without approvers).
VCS Details
VCS: GitLab
Project Settings:
Protected branches -> Code owner approval (main)
Merge requests -> Pipelines must succeed
Reproduction Steps
Run atlantis apply without approvers on the merge request
Expected error: Apply Failed: Pull request must be approved by at least one person other than the author before running apply.
Approve the merge request
Run apply again
Unexpected error: Apply Failed: Pull request must be mergeable before running apply.
Run plan
For any new apply on this MR: Apply Failed: Pull request must be mergeable before running apply.
Logs
There is no error in the logs
Environment details
Atlantis version: Problem started on v0.18.0, still occurs on latest
michelmzs
changed the title
Deadlock condition - Unable to apply MR after apply requirements failure
Unable to apply MR after requirements failure
Mar 12, 2022
* fix: update commit status check logic to match the commit status name
* Update server/events/vcs/gitlab_client.go
chore: simplify ignored statuses logic
Co-authored-by: Emil 'Skeen' Madsen <[email protected]>
* feat(gitlab_client_test): add PullIsMergeable test case
Co-authored-by: Emil 'Skeen' Madsen <[email protected]>
…ntis#2137)
* fix: update commit status check logic to match the commit status name
* Update server/events/vcs/gitlab_client.go
chore: simplify ignored statuses logic
Co-authored-by: Emil 'Skeen' Madsen <[email protected]>
* feat(gitlab_client_test): add PullIsMergeable test case
Co-authored-by: Emil 'Skeen' Madsen <[email protected]>
Community Note
Overview of the Issue
Atlantis cannot apply when a failure occurs due to lack of
apply_requirements
, even if the requirements have been met after.In this case, the
mergeable
requirement always fails because one of the apply jobs in the pipeline failed (apply without approvers).VCS Details
Reproduction Steps
Logs
There is no error in the logs
Environment details
Atlantis server-side config file:
Atlantis repo-side config file:
Additional Context
The text was updated successfully, but these errors were encountered: