Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Atlantis 0.4 #152

Merged
merged 69 commits into from
Jul 3, 2018
Merged

[WIP] Atlantis 0.4 #152

merged 69 commits into from
Jul 3, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jun 19, 2018

Todo

Features

  • user docs
  • backwards compat for --require-approval flag
  • add --enable-repoconfig flag that enables atlantis.yaml files since they're a security vulnerability

Code Quality

  • decide on naming
  • finish unit tests
  • regen all mocks
  • godocs

lkysow added 30 commits June 5, 2018 17:06
This change makes things cleaner because there will only ever be one
plan generated in the comment flow. It's okay to make this change
because typing the plan command a couple times isn't too bad AND we're
going to be implementing autoplanning which should handle most of the
times you needed to type plan from before.
Even though we're switching to the right workspace this is a nice
safeguard to have. I don't think it incurs additional time.
- Fix lockURL issues by adding new Router object.
- Use new ProjectLocker and delete PreProjectExecutor.
@lkysow lkysow force-pushed the atlantis-yaml-june branch from 8b245d0 to e4bf6d7 Compare June 30, 2018 21:24
@lkysow lkysow force-pushed the atlantis-yaml-june branch from e4bf6d7 to 13a70c7 Compare June 30, 2018 21:27
@bewie
Copy link
Contributor

bewie commented Jul 2, 2018

Hi,
I tried your current work in this PR, I my case with terraform v0.11.7 I got an error on terraform_client.go during the workspace selection (sh -c terraform workspace select -no-color default).

The selected workspace is currently overridden using the TF_WORKSPACE
environment variable.

To select a new workspace, either update this environment variable or unset
it and then run this command again.

It seems to be the expected behavior in terraform : https://github.com/hashicorp/terraform/blob/master/command/workspace_select.go#L46

I think the addition of TF_WORKSPACE in env var can be an problem.

@lkysow
Copy link
Member Author

lkysow commented Jul 2, 2018

@bewie okay great good to know, I'll remove that since it's not needed because I manually switch workspaces. Thanks!

@lkysow
Copy link
Member Author

lkysow commented Jul 2, 2018

@bewie I pushed new commits to this branch that remove that variable.

@bewie
Copy link
Contributor

bewie commented Jul 2, 2018

@lkysow , I tested on my side it's works! 👍
thx.

lkysow added 3 commits July 2, 2018 19:01
- delete working dir when lock deleted
- check if dir still exists when looking at modified
- check if atlantis.yaml is allowed before parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants