Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a way to disable apply? #50

Closed
atlantisbot opened this issue Mar 6, 2018 · 5 comments
Closed

There is a way to disable apply? #50

atlantisbot opened this issue Mar 6, 2018 · 5 comments
Milestone

Comments

@atlantisbot
Copy link

Issue by @tsiq-cejas
Wednesday Feb 21, 2018 at 19:30 GMT
Migrated from hootsuite/atlantis#246
Why was it migrated?


There is any way to disable/control who can trigger an atlantis apply?

@atlantisbot
Copy link
Author

Comment by @lkysow
Wednesday Feb 21, 2018 at 19:56 GMT


You can set --require-approval when running atlantis server. This will
require a pull request approval prior to allowing apply.

In the next release you'll be able to control this further by using GitHub
CODEOWNERS.

On Wed, Feb 21, 2018, 11:30 AM Ernesto Cejas Padilla <
[email protected]> wrote:

There is any way to disable/control who can trigger an atlantis apply?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
hootsuite/atlantis#246, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_IvTzsNk_J-ZKl7UbPgJojvqEDQlIzks5tXG7NgaJpZM4SOMoS
.

@atlantisbot
Copy link
Author

Comment by @tsiq-cejas
Wednesday Feb 21, 2018 at 20:11 GMT


Thanks, what about a way of disabling it completely? This is useful when
you are using other tools to apply your changes.

On Wed, Feb 21, 2018 at 2:56 PM Luke Kysow [email protected] wrote:

You can set --require-approval when running atlantis server. This will
require a pull request approval prior to allowing apply.

In the next release you'll be able to control this further by using GitHub
CODEOWNERS.

On Wed, Feb 21, 2018, 11:30 AM Ernesto Cejas Padilla <
[email protected]> wrote:

There is any way to disable/control who can trigger an atlantis apply?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
hootsuite/atlantis#246, or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AA_IvTzsNk_J-ZKl7UbPgJojvqEDQlIzks5tXG7NgaJpZM4SOMoS

.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
hootsuite/atlantis#246 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ac3tw2ZovHCm9rw6qKHUswp0lK93bPEEks5tXHTggaJpZM4SOMoS
.

@atlantisbot
Copy link
Author

Comment by @lkysow
Wednesday Feb 21, 2018 at 23:57 GMT


Not right now. In the next release you'll be able to set custom steps for an apply, so you could set a a single step like exit 1 and it would never apply.

Questions for you: are you interested in using Atlantis just for the comment on the pull request then? Also I'm curious what tools you're using to apply your changes? Just interested in your use-case because others might have it too.

@atlantisbot
Copy link
Author

Comment by @tsiq-cejas
Friday Feb 23, 2018 at 17:41 GMT


thanks,

  1. Yes, I am interested in using Atlantis just for the comment on the pull
    request. Is too risky that anyone can apply right now.
  2. Right now a mix of manual with travis applies.

On Wed, Feb 21, 2018 at 6:57 PM Luke Kysow [email protected] wrote:

Not right now. In the next release you'll be able to set custom steps for
an apply, so you could set a a single step like exit 1 and it would never
apply.

Questions for you: are you interested in using Atlantis just for the
comment on the pull request then? Also I'm curious what tools you're using
to apply your changes? Just interested in your use-case because others
might have it too.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
hootsuite/atlantis#246 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ac3tw6wngIrYnjpqI7KScgeuLwnqxYFDks5tXK1QgaJpZM4SOMoS
.

@lkysow
Copy link
Member

lkysow commented Jul 4, 2018

Closed by #152. In version 0.4 now.

You can add an atlantis.yaml file at the repo root and then set the apply workflow to be a no-op.

# atlantis.yaml
version: 2
projects:
- dir: .
  workflow: noapply
# list all your projects
workflows:
  noapply:
    apply:
      steps: [] # There are no steps so nothing will happen.

@lkysow lkysow closed this as completed Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants