Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide previous comments when they are split #1060

Closed
wants to merge 1 commit into from
Closed

Hide previous comments when they are split #1060

wants to merge 1 commit into from

Conversation

bewie
Copy link
Contributor

@bewie bewie commented May 29, 2020

Since the v0.12 Atlantis can hide the previous "plan" comments.
But when a comment is split into several comments due to his size, only the first part of the plan is hidden.

Related to #1021

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #1060 into master will increase coverage by 0.01%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
+ Coverage   71.47%   71.48%   +0.01%     
==========================================
  Files          67       67              
  Lines        5556     5559       +3     
==========================================
+ Hits         3971     3974       +3     
  Misses       1271     1271              
  Partials      314      314              
Impacted Files Coverage Δ
server/events/vcs/github_client.go 81.03% <89.47%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1682c6...29a2ad6. Read the comment docs.

@lkysow
Copy link
Member

lkysow commented Jul 7, 2020

I think this is solved by #1034.

@lkysow lkysow closed this Jul 7, 2020
@bewie bewie deleted the lapollis/hide_previous_comment branch July 7, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants