Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Hide previous comments doesn't mark all as hidden #1021

Closed
GabeL7r opened this issue Apr 30, 2020 · 1 comment
Closed

[BUG] Hide previous comments doesn't mark all as hidden #1021

GabeL7r opened this issue Apr 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@GabeL7r
Copy link

GabeL7r commented Apr 30, 2020

When the Terraform plan has multiple comments only the first one gets marked as hidden. I think this is because of the filtering done here: https://github.com/runatlantis/atlantis/pull/994/files#diff-e348084f0b7562996b0bd5d429158e53R177

This should also catch Continued from previous comment.
@crainte crainte mentioned this issue May 12, 2020
Merged
@lkysow lkysow added the bug Something isn't working label May 25, 2020
@bewie bewie mentioned this issue May 29, 2020
Closed
@angeloskaltsikis angeloskaltsikis mentioned this issue Jun 29, 2020
Open
@lkysow
Copy link
Member

lkysow commented Jul 7, 2020

Fixed by #1034

@lkysow lkysow closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkysow @GabeL7r