Improve TextField.autoSize, implement TextField.background

[adrian17]

First commit makes TextField better respect properties of autoSize: with "left", it extends to the right from _x; with "right", it extends to the left from _x+_width. This doesn't affect text layout; just where the text field appears in the end.
This is not a full fix of any issue; in fact, this doesn't fix completely any issues, just improve them a bit. In particular, various missing parts I noticed:

• there are minor margin-related differences from Flash (you can see the last digit "0" being cut off on screenshots below; that's also why tests run in approximate mode)
• text re-layout should occur lazily (think like console.log(el.offsetLeft) triggers reflow in JS), not on each property set
• autoSize="right" should overrule textFormat.align and align text to right;
• In Text shown in SWF is not in the right place and cut off, and text shown when hovering is inaccurate too #3156, it still sometimes behaves weirdly and I don't fully understand why.

As for improvements:

• Hovering text is broken in Sonny #1095 - tooltips no longer appears on top of cursor, so buttons are finally clickable (the layout is still as broken as before though)
• Nanaca Crash: Misaligned 'record' numbers #1440 - "new record" etc appear where it should, but slightly overlap with the "m"
• Text shown in SWF is not in the right place and cut off, and text shown when hovering is inaccurate too #3156 - text appears closer to where it should be, but still not 100% correct.
• makes borders refresh on re-layout if autoSize is enabled
• implements TextField.background flag - before, we would draw background whenever border=true, which wasn't correct.

Screenshots:

• test, Flash Player (respectively: reference text, dynamic text with no autoSize, then texts with autoSize=left, center, right):
  
• test, Ruffle, before PR:
  
• test, Ruffle, with PR:
  
• Sonny:
  
• Text shown in SWF is not in the right place and cut off, and text shown when hovering is inaccurate too #3156 no hover:
  
• Text shown in SWF is not in the right place and cut off, and text shown when hovering is inaccurate too #3156 on hover (better than before but sometimes still weirdly too much too the right):
  
  Nanaca Crash: Misaligned 'record' numbers #1440:
  

[seanpm2001]

It looks good. Everything is clean and functional.

[kmeisthax]

Same here.

I'll point out that you should also make sure the other EditText tests don't have a rendering regression. I structured them to double as both traceable and renderable regression tests, so you should run them on Desktop & compare with Flash Player or ruffle/master as well.

[danielhjacobs]

As the author of #3156 this looks promising, though obviously it would be better for me if it fully fixed that issue.

Semi-related; this may not be the best place for this comment, but I thought I'd mention this since my issue was mentioned:

I added more SWFs with the same problem to the issue. They are nearly identical files, but maybe they will give a clue as to the behavior that you "don't fully understand". I thought they were redundant, but better to include too much detail than too little.

Edit: Further testing revealed a slight difference in the problems with some of the SWFs versus others. See latest comment on the issue for further details since this is not the place for me to mention them.

[adrian17]

I'll point out that you should also make sure the other EditText tests don't have a rendering regression

I hoped the existing tests would "handle themselves" without having me actually look at them (especially if they pass) :)
But sure, I can take a look at them (I don't think most of them actually use autoSize, so hopefully they shouldn't be affected).

[adrian17]

@craniumcadoo FYI:

Upon moving the mouse to hover over (4), then (5), then back to (4), then ... repeatedly, the text just keeps moving further right, until it is eventually offscreen completely.

From what I see, my patch seems to fix this particular behavior.

[adrian17]

Also none of the existing EditText tests are affected, from visual inspection.