Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text shown in SWF is not in the right place and cut off, and text shown when hovering is inaccurate too #3156

Closed
danielhjacobs opened this issue Feb 8, 2021 · 5 comments · Fixed by #18494
Labels
bug Something isn't working text Issues relating to text rendering/input

Comments

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Feb 8, 2021

Describe the bug

This is a visual bug and a bit hard to explain. The bug can be seen in action when using the browser extension here:

(Note: not reproducible anymore, see below for a SWF)
HTML Page: http://www.dnai.org/timeline/index.html
SWF File: http://www.dnai.org/timeline/timeline_header.swf

Expected behavior

The problem is a bit hard to explain, so I have an image that explains it better than I can:
ruffle_header_differences

Is the problem with the Ruffle desktop app, extension, or self-hosted version?

It applies to the extension and demo, and based on testing on my test server, also to the self-hosted version. Since it's a rendering/formatting issue, it seems to apply to every version

What platform are you using?

I am using a Windows 10 computer, and tested both Chrome and Firefox

@danielhjacobs danielhjacobs added the bug Something isn't working label Feb 8, 2021
@danielhjacobs danielhjacobs changed the title Text shown in SWF image is not in the right place, and text shown when hovering is inaccurate too Text shown in SWF image is not in the right place and cut off, and text shown when hovering is inaccurate too Feb 8, 2021
@danielhjacobs danielhjacobs changed the title Text shown in SWF image is not in the right place and cut off, and text shown when hovering is inaccurate too Text shown in SWF is not in the right place and cut off, and text shown when hovering is inaccurate too Feb 8, 2021
@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Feb 11, 2021

I see there is a pull request out that would fix part of the issue, but that the author of said pull request (@adrian17) said they don't fully understand the rest of the issue.

I doubted having more SWF files that are almost exactly the same and all have the exact same error would help identify the issue, which is why I did not include those files initially since I thought it would be redundant. but in case it helps, the following all have the exact same issue:

(Note: not reproducible anymore, see below for a SWF)

@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Feb 11, 2021

Further testing:

http://www.dnai.org/timeline/, http://www.dnai.org/c/, and http://www.dnai.org/e/ - Upon moving the mouse to hover over (4), then (5), then back to (4), then ... repeatedly, the text just keeps moving further right, until it is eventually offscreen completely.

I believe the same applies to http://www.dnai.org/a/, however for that one, more often than not, the text starts so far to the right that it is already offscreen initially.

http://www.dnai.org/b/, http://www.dnai.org/d/ - On these two pages, the same action moves the text to the left until it is offscreen.

Edit: No longer relevant

@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Feb 14, 2021

Since 26ffbdf was committed, the issue is a lot less problematic. The text is still not in the right place a lot of the time, but its position is a lot more consistent and close to where it's meant to be. It no longer jumps around. Check the swfs/pages to see the issue in action now.

@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Mar 2, 2021

I don't know whether to close this or not, so I'm leaving it open and I'll let someone with the authority to close issues decide whether to close it. It was not fixed. However, since it did not seem to be progressing, we updated those animations, so the issue is no longer visible by viewing them. Uploaded zip exemplifying the issue (very old version of a file showing the same issue).
header_mc5.zip

@n0samu n0samu added the text Issues relating to text rendering/input label Jun 21, 2023
@n0samu
Copy link
Member

n0samu commented Jun 21, 2023

I think this is an instance of #10660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working text Issues relating to text rendering/input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants