Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Use ruby/setup-ruby instead of deprecated one #710

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Use ruby/setup-ruby instead of deprecated one #710

merged 2 commits into from
Mar 14, 2021

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Mar 14, 2021

https://github.com/rubyide/vscode-ruby/runs/2107273120 fails with following message

Run actions/setup-ruby@v1
  with:
    ruby-version: 2.4
------------------------
NOTE: This action is deprecated and is no longer maintained.
Please, migrate to https://github.com/ruby/setup-ruby, which is being actively maintained.
------------------------
Error: Version 2.4 not found

So just tried to use it... 🤔

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #710 (b65920a) into master (9f12c66) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #710   +/-   ##
======================================
  Coverage    5.08%   5.08%           
======================================
  Files          10      10           
  Lines         118     118           
  Branches       20      20           
======================================
  Hits            6       6           
  Misses        112     112           
Flag Coverage Δ
language_server_ruby 5.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f12c66...b65920a. Read the comment docs.

@kachick
Copy link
Contributor Author

kachick commented Mar 14, 2021

ref: actions/setup-ruby#97 👀

@kachick kachick mentioned this pull request Mar 14, 2021
3 tasks
@kachick
Copy link
Contributor Author

kachick commented Mar 14, 2021

Failing only in Ruby 2.5.8 with debase gem

https://github.com/rubyide/vscode-ruby/pull/710/checks?check_run_id=2107314420

Building native extensions. This could take a while...
ERROR:  Error installing debase:
1 gem installed
	ERROR: Failed to build gem native extension.

    current directory: /Users/runner/hostedtoolcache/Ruby/2.5.8/x64/lib/ruby/gems/2.5.0/gems/debase-0.2.4.1/ext
/Users/runner/hostedtoolcache/Ruby/2.5.8/x64/bin/ruby -r ./siteconf20210314-7558-1r0wfrn.rb extconf.rb
checking for vm_core.h... no
checking for vm_core.h... no
**************************************************************************
No source for ruby-2.5.8-p224 (revision 67882) provided with
debase-ruby_core_source gem. Falling back to ruby-2.5.1-p57.
**************************************************************************
checking for vm_core.h... yes
checking for iseq.h... yes
checking for version.h... yes
checking for vm_core.h... yes
checking for vm_insnhelper.h... yes
checking for vm_core.h... yes
checking for method.h... yes
creating Makefile

current directory: /Users/runner/hostedtoolcache/Ruby/2.5.8/x64/lib/ruby/gems/2.5.0/gems/debase-0.2.4.1/ext
make "DESTDIR=" clean

current directory: /Users/runner/hostedtoolcache/Ruby/2.5.8/x64/lib/ruby/gems/2.5.0/gems/debase-0.2.4.1/ext
make "DESTDIR="
compiling breakpoint.c
compiling context.c
compiling debase_internals.c
debase_internals.c:319:25: warning: initializing 'rb_control_frame_t *' (aka 'struct rb_control_frame_struct *') with an expression of type 'const rb_control_frame_t *' (aka 'const struct rb_control_frame_struct *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
    rb_control_frame_t *start_cfp = RUBY_VM_END_CONTROL_FRAME(TH_INFO(thread));
                        ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
debase_internals.c:697:24: warning: initializing 'rb_iseq_t *' (aka 'struct rb_iseq_struct *') with an expression of type 'const rb_iseq_t *' (aka 'const struct rb_iseq_struct *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
            rb_iseq_t *iseq = my_iseqw_check(rb_iseq);
                       ^      ~~~~~~~~~~~~~~~~~~~~~~~
debase_internals.c:700:17: error: implicit declaration of function 'rb_iseq_trace_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                rb_iseq_trace_set(iseq, RUBY_EVENT_TRACEPOINT_ALL);
                ^
debase_internals.c:708:24: warning: initializing 'rb_iseq_t *' (aka 'struct rb_iseq_struct *') with an expression of type 'const rb_iseq_t *' (aka 'const struct rb_iseq_struct *') discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
            rb_iseq_t *iseq = my_iseqw_check(rb_iseq);
                       ^      ~~~~~~~~~~~~~~~~~~~~~~~
debase_internals.c:711:17: error: implicit declaration of function 'rb_iseq_trace_set' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                rb_iseq_trace_set(iseq, RUBY_EVENT_NONE);
                ^
debase_internals.c:768:64: warning: incompatible pointer types passing 'void (VALUE, VALUE)' (aka 'void (unsigned long, unsigned long)') to parameter of type 'VALUE (*)()' (aka 'unsigned long (*)()') [-Wincompatible-pointer-types]
  rb_define_module_function(mDebase, "set_trace_flag_to_iseq", Debase_set_trace_flag_to_iseq, 1);
                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/hostedtoolcache/Ruby/2.5.8/x64/include/ruby-2.5.0/ruby/ruby.h:1716:57: note: passing argument to parameter here
void rb_define_module_function(VALUE,const char*,VALUE(*)(ANYARGS),int);
                                                        ^
debase_internals.c:771:58: warning: incompatible pointer types passing 'void (VALUE, VALUE)' (aka 'void (unsigned long, unsigned long)') to parameter of type 'VALUE (*)()' (aka 'unsigned long (*)()') [-Wincompatible-pointer-types]
  rb_define_module_function(mDebase, "unset_iseq_flags", Debase_unset_trace_flags, 1);
                                                         ^~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/hostedtoolcache/Ruby/2.5.8/x64/include/ruby-2.5.0/ruby/ruby.h:1716:57: note: passing argument to parameter here
void rb_define_module_function(VALUE,const char*,VALUE(*)(ANYARGS),int);
                                                        ^
5 warnings and 2 errors generated.
make: *** [debase_internals.o] Error 1

make failed, exit code 2

Gem files will remain installed in /Users/runner/hostedtoolcache/Ruby/2.5.8/x64/lib/ruby/gems/2.5.0/gems/debase-0.2.4.1 for inspection.
Results logged to /Users/runner/hostedtoolcache/Ruby/2.5.8/x64/lib/ruby/gems/2.5.0/extensions/x86_64-darwin-19/2.5.0/debase-0.2.4.1/gem_make.out
Error: Process completed with exit code 1.

ruby-debug/debase#88 (comment) 👀

@wingrunr21 wingrunr21 merged commit 7b5b602 into rubyide:master Mar 14, 2021
@kachick
Copy link
Contributor Author

kachick commented Mar 14, 2021

Thank you!

@kachick kachick deleted the use-ruby-setup-ruby branch March 14, 2021 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants