Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Fix some typos #709

Merged
merged 4 commits into from
Apr 14, 2021
Merged

Fix some typos #709

merged 4 commits into from
Apr 14, 2021

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Mar 14, 2021

When I'm digging a syntax highlight issue, found these typos. 😄

  • The build passes
  • TSLint is mostly happy
  • Prettier has been run

@kachick
Copy link
Contributor Author

kachick commented Mar 14, 2021

The Ruby 2.4 CI failure might be fixed in #710 🤔

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #709 (bc8db62) into master (7b5b602) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #709   +/-   ##
======================================
  Coverage    5.08%   5.08%           
======================================
  Files          10      10           
  Lines         118     118           
  Branches       20      20           
======================================
  Hits            6       6           
  Misses        112     112           
Flag Coverage Δ
language_server_ruby 5.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5b602...bc8db62. Read the comment docs.

@github-actions
Copy link

This PR has not had activity for 30 days. It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Apr 14, 2021
@kachick
Copy link
Contributor Author

kachick commented Apr 14, 2021

"information_for_contributors": [
"This file has been converted from https://github.com/atom/language-ruby/blob/master/grammars/ruby.cson",
"If you want to provide a fix or improvement, please create a pull request against the original repository.",
"Once accepted there, we are happy to receive an update request."
],

I have already sent PR as atom/language-ruby#294, but it is not been merged 😢

@wingrunr21
Copy link
Collaborator

I'm not using the upstream grammar anymore. There were too many unmerged fixes to it.

@wingrunr21 wingrunr21 merged commit 371be57 into rubyide:master Apr 14, 2021
@kachick
Copy link
Contributor Author

kachick commented Apr 18, 2021

I'm not using the upstream grammar anymore. There were too many unmerged fixes to it.

It sounds reasonable 👍

Thanks for the merging!

@kachick kachick deleted the fix-some-typos branch April 18, 2021 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants