Do not compile the C extension on TruffleRuby #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2023
kou
approved these changes
Nov 27, 2023
* Before this it was compiled but not used, because TruffleRuby has a stringio.rb in stdlib and .rb has precedence over .so. In fact that extension never worked on TruffleRuby, because rb_io_extract_modeenc() has never been defined on TruffleRuby. * So this just skip compiling the extension since compilation of it now fails: ruby/openssl#699
eregon
force-pushed
the
do-not-compile-on-truffleruby
branch
from
5fd530a
to
c2b09a6
Compare
|
@kou All done now. |
nobu
approved these changes
Nov 27, 2023
nobu
added a commit
that referenced
this pull request
Nov 27, 2023
st0012
added a commit
to ruby/irb
that referenced
this pull request
Nov 27, 2023
The fix has been merged but not released yet: ruby/stringio#71
|
Released! |
|
Thank you for releasing the stringio 3.1.0! |
|
Thanks for the release. |
st0012
added a commit
to ruby/irb
that referenced
this pull request
Nov 28, 2023
The fix has been merged but not released yet: ruby/stringio#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach is similar to the one in strscan, notably:
TruffleRuby is not added in CI because there are quite a few failures:
It makes more sense to fix https://github.com/oracle/truffleruby/blob/master/lib/truffle/stringio.rb to pass more of the tests before adding TruffleRuby to the CI.
Note that
gem install stringioand anyGemfiletransitively includingstringiois broken on truffleruby-dev until this is merged and released.So it would be awesome if we could have a quick release of
stringiowith this fix.