Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stringio 3.0.9 fails to install/compile on truffleruby-dev, RBASIC(strio)->flags #3328

Closed
eregon opened this issue Nov 24, 2023 · 3 comments
Closed
Labels

Comments

@eregon
Copy link
Member

eregon commented Nov 24, 2023

From ruby/openssl#699

$ gem i stringio
Fetching stringio-3.0.9.gem
Building native extensions. This could take a while...
ERROR:  Error installing stringio:
	ERROR: Failed to build gem native extension.

    current directory: /home/eregon/.rubies/truffleruby-dev/lib/gems/gems/stringio-3.0.9/ext/stringio
/home/eregon/.rubies/truffleruby-dev/bin/ruby extconf.rb
creating Makefile

current directory: /home/eregon/.rubies/truffleruby-dev/lib/gems/gems/stringio-3.0.9/ext/stringio
make DESTDIR\= sitearchdir\=./.gem.20231124-41381-hl1rfa sitelibdir\=./.gem.20231124-41381-hl1rfa clean

current directory: /home/eregon/.rubies/truffleruby-dev/lib/gems/gems/stringio-3.0.9/ext/stringio
make DESTDIR\= sitearchdir\=./.gem.20231124-41381-hl1rfa sitelibdir\=./.gem.20231124-41381-hl1rfa
compiling stringio.c
stringio.c: In function ‘readable’:
stringio.c:138:7: error: implicit declaration of function ‘RBASIC’ [-Werror=implicit-function-declaration]
  138 |     ((RBASIC(strio)->flags & STRIO_##mode) && \
      |       ^~~~~~
stringio.c:141:25: note: in expansion of macro ‘STRIO_MODE_SET_P’
  141 | #define READABLE(strio) STRIO_MODE_SET_P(strio, READABLE)
      |                         ^~~~~~~~~~~~~~~~
stringio.c:150:10: note: in expansion of macro ‘READABLE’
  150 |     if (!READABLE(strio)) {
      |          ^~~~~~~~

This is expected since #3118.
Fix for upstream in ruby/stringio#71

@eregon eregon changed the title stringio 3.0.9 fails to install/compile on truffleruby, RBASIC(strio)->flags stringio 3.0.9 fails to install/compile on truffleruby-dev, RBASIC(strio)->flags Nov 24, 2023
@eregon eregon added the cexts label Nov 24, 2023
@eregon
Copy link
Member Author

eregon commented Nov 28, 2023

Fixed in stringio 3.1.0: ruby/stringio#71 (comment)

@eregon eregon closed this as completed Nov 28, 2023
@eregon
Copy link
Member Author

eregon commented Nov 28, 2023

Unfortunately there is a rubygems.org issue currently which means stringio 3.1.0 might not be picked up in CI: rubygems/rubygems.org#4247

@eregon
Copy link
Member Author

eregon commented Nov 28, 2023

That rubygems.org issue is fixed now: rubygems/rubygems.org#4247 (comment)

p0deje added a commit to bazel-contrib/rules_ruby that referenced this issue Mar 21, 2024
This fixes it to work on TruffleRuby 2.24
oracle/truffleruby#3328
p0deje added a commit to bazel-contrib/rules_ruby that referenced this issue Mar 21, 2024
This fixes it to work on TruffleRuby 2.24
oracle/truffleruby#3328
p0deje added a commit to bazel-contrib/rules_ruby that referenced this issue Mar 21, 2024
This fixes it to work on TruffleRuby 2.24
oracle/truffleruby#3328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant