Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom test library replace to test-unit gem #32

Merged
merged 1 commit into from
Jul 14, 2019

Conversation

komagata
Copy link
Contributor

Remove custom test library.
I transport only custom assertions into assertions.rb.

Reference: #27

custom assertions:

  • assert_in_out_err
  • assert_separately
  • assert_file

Remove custom test/unit and minitest.
Transport only original assert methods into assertions.rb.
@sonots
Copy link
Member

sonots commented May 21, 2019

Thanks! I will check later!

@hsbt
Copy link
Member

hsbt commented May 22, 2019

I prefer this patch. I will consider backporting this change to the ruby core repository after merging.

@hsbt hsbt merged commit 79febff into ruby:master Jul 14, 2019
@hsbt
Copy link
Member

hsbt commented Jul 14, 2019

@sonotsI I merged this because I start to work to migrate this change on the ruby core repository. If you have any concerns, Please ping me on the bugs.ruby-lang.org or this repostiory.

@sonots
Copy link
Member

sonots commented Jul 15, 2019

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants