Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAN] Use test-unit and power-assert gem #27

Closed
sonots opened this issue Mar 21, 2019 · 2 comments
Closed

[PLAN] Use test-unit and power-assert gem #27

sonots opened this issue Mar 21, 2019 · 2 comments

Comments

@sonots
Copy link
Member

sonots commented Mar 21, 2019

instead of built-in custom test library https://github.com/ruby/logger/tree/master/test/lib.

@hsbt
Copy link
Member

hsbt commented Mar 21, 2019

+1

The current test suite of logger uses assert_separately provided by the custom test-unit on ruby core repository.

https://github.com/ruby/logger/blob/master/test/logger/test_logdevice.rb#L608

We should replace it or make its assertion independent.

@sonots
Copy link
Member Author

sonots commented Jul 15, 2019

fixed via #32

@sonots sonots closed this as completed Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants