don't cache the base_path #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. This needs a spec and a CHANGELOG entry please. |
|
To be honest... I don't really think there's much of a test suite here anyway. I don't see a single assertion in the It's pretty hard to make heads or tails of this whole repo due to its implementation. Feel free to accept it or close it if you'd rather. |
|
You're looking in the wrong place :) The spec folder has a lot of RSpec tests. The test should really be called demo. I'll rename it at some point. |
|
Regarding the implementation, totally. The project evolved somewhat "organically". Hopefully someone will take a stab at rewriting most of this. |
|
Added spec/changelog in https://github.com/tim-vandecasteele/grape-swagger/pull/181. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base_path for some reason was being cached as a class local variable (even if you provide a proc in the config). This means that if you have a mutli-tenanted api (for instance
app1.myapp.com/apiandapp2.myapp.com/api) if you switch between those 2 api docs, thebaseUrlwould always be the first one that the site accessed since it's cached on load.There's really no reason to cache this, it should just be evaluated for each request.