Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for workspace core service (#191) #197

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Sep 22, 2023

  • workspace integration branch pr patch which includes:
  1. WorkspaceService unit test
  2. Some renames

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

+ workspace integration branch pr patch

Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #197 (3302635) into workspace (a2abcf2) will increase coverage by 0.02%.
Report is 1 commits behind head on workspace.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           workspace     #197      +/-   ##
=============================================
+ Coverage      66.09%   66.12%   +0.02%     
=============================================
  Files           3420     3420              
  Lines          65752    65753       +1     
  Branches       10589    10590       +1     
=============================================
+ Hits           43461    43480      +19     
+ Misses         19650    19633      -17     
+ Partials        2641     2640       -1     
Flag Coverage Δ
Linux_1 30.42% <33.33%> (+<0.01%) ⬆️
Linux_2 55.12% <100.00%> (+0.06%) ⬆️
Linux_3 42.76% <33.33%> (+0.01%) ⬆️
Linux_4 34.52% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/public/chrome/chrome_service.tsx 91.42% <ø> (ø)
...c/core/public/chrome/ui/header/collapsible_nav.tsx 98.11% <ø> (ø)
...public/chrome/ui/header/collapsible_nav_header.tsx 60.00% <ø> (ø)
src/core/public/chrome/ui/header/header.tsx 75.00% <ø> (ø)
src/core/public/mocks.ts 59.09% <ø> (ø)
src/core/public/workspace/workspaces_service.ts 96.29% <ø> (+59.25%) ⬆️
...blic/application/opensearch_dashboards_services.ts 20.00% <ø> (ø)
...ction/objects_table/components/duplicate_modal.tsx 0.00% <ø> (ø)
...ment_section/objects_table/saved_objects_table.tsx 57.35% <ø> (ø)
src/core/public/core_system.test.mocks.ts 100.00% <100.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanyl ruanyl merged commit ecff529 into workspace Sep 25, 2023
21 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants