forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for workspace core service #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
requested review from
wanglam,
SuZhou-Joe,
gaobinlong,
yuye-aws,
raintygao and
Hailong-am
September 21, 2023 05:55
Codecov Report
@@ Coverage Diff @@
## workspace-pr-integr #191 +/- ##
=======================================================
+ Coverage 66.44% 66.47% +0.02%
=======================================================
Files 3408 3408
Lines 65149 65155 +6
Branches 10431 10431
=======================================================
+ Hits 43291 43311 +20
+ Misses 19264 19249 -15
- Partials 2594 2595 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wanglam
approved these changes
Sep 22, 2023
raintygao
approved these changes
Sep 22, 2023
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
force-pushed
the
test-for-workspace-core-service
branch
from
September 22, 2023 07:50
a0fecc7
to
d7e2691
Compare
ruanyl
added a commit
that referenced
this pull request
Sep 22, 2023
+ workspace integration branch pr patch Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
added a commit
that referenced
this pull request
Sep 22, 2023
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
added a commit
that referenced
this pull request
Sep 25, 2023
rename workspace service class name and types --------- Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
added a commit
that referenced
this pull request
Sep 28, 2023
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
added a commit
that referenced
this pull request
Oct 13, 2023
Signed-off-by: Yulong Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added unit tests for core
WorkspacesService
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr