-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for extending the cycle counter to u64 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables tracking time intervals of more than a couple seconds on modern processors.
In extend=true, the reload interrupt is not disabled (for overflow detection), the previous `set_compare()` may have been called with a short interval, then, if the queue is empty, the reload interrupt would fire at very short interval.
jordens
force-pushed
the
feature/extend
branch
2 times, most recently
from
February 4, 2022 11:43
6b68cb4
to
9f5ae47
Compare
Also add comments clarifying the now() calls
jordens
force-pushed
the
feature/extend
branch
from
February 4, 2022 11:43
9f5ae47
to
169db54
Compare
* Move the SysTick clock source configuration to `new()`. * Add comments about the double reset of the cycle counter.
AfoHT
reviewed
Feb 8, 2022
depend on cortex-m 0.7.4 for `DWT::cycle_count()` Co-authored-by: Henrik Tjäder <[email protected]>
AfoHT
reviewed
Feb 15, 2022
korken89
previously approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort!
korken89
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables tracking time intervals of more than a couple seconds on
modern processors.
Tested on hardware (stm32h743, 400 MHz, https://github.com/quartiq/stabilizer) with spawn across overflows.