Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back propagation #259

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Back propagation #259

merged 4 commits into from
Sep 2, 2024

Conversation

berthetclement
Copy link
Collaborator

The aim is to update the develop branch with the CRAN acceptance criteria.

* update github workflow

* Read cluster desc bugfix when cluster exist (#242)

* fix bug readClusterDesc when no cluster + cover ST and RES case

* add test (init test for thermal + res)

* cleaning

* fix cran NOTE causing by bad url in doc + bad doc

### Breaking changes (Antares v8.7.0) : 

* `readBindingConstraints()` read now Scenarized RHS for binding constraints (cf. Antares v8.7 changelog)
  - function returns a new list structure
* Private function `fread_antares()` no longer returns warnings  
* `api_put()/api_delete()` return a server error message 

BUGFIXES :  

* `readBindingConstraints()` read well study >= v8.3.2

DATA : 

* A test study in tar.gz format is available in version v8.7.0  
* An empty test study in version v8.7.0 for marginal cases 

Dependencies :  

* New package `lifecycle` to manage functions status/package status
* update github workflow

* Read cluster desc bugfix when cluster exist (#242)

* fix bug readClusterDesc when no cluster + cover ST and RES case

* add test (init test for thermal + res)

* Release/cran261 (#244) (#245)

update with developments made during the CRAN release phase

* Add argument encoding in api_get() (#246)

* Add encoding argument to api_get()

* [readIniFile] : avoid `utils::type.convert` on specific cases (ex : 789e or 123i)  (#247)

* Add specific case to avoid bad convert

* Add unit test file for readIniFile

* Release/v8.7.0 (#224)

### Breaking changes (Antares v8.7.0) : 

* `readBindingConstraints()` read now Scenarized RHS for binding constraints (cf. Antares v8.7 changelog)
  - function returns a new list structure
* Private function `fread_antares()` no longer returns warnings  
* `api_put()/api_delete()` return a server error message 

BUGFIXES :  

* `readBindingConstraints()` read well study >= v8.3.2

DATA : 

* A test study in tar.gz format is available in version v8.7.0  
* An empty test study in version v8.7.0 for marginal cases 

Dependencies :  

* New package `lifecycle` to manage functions status/package status

* Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster (#243)

* Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster

* .importThermalData fixed to be compatible with data daily format

* fix test thermal + add test RES

* update

* Ant1777/dimbcgroup (#251)

* setSimulationPath() updated with new private function to add meta data group dimension for binding constraints

* setSimulationPath() doc updated with new parameter

* Read ST clusters with readAntares() (#252)

* Add .importOutputForSTClusters()

* Add 'clustersST' argument in readAntares()

* create a wrapper for calling .reshape_details_file()

* Simplify .get_value_columns_details_file() with a reference table

* Correct areasWithSTClusters parameter in .getSimOptions()

* Add unit tests for 'areasWithSTClusters' parameter

* Add DETAILS_FILES_TYPE column in the simulation_variables_names_by_support.csv

* Update NEWS.md

* Make new parameter 'clustersST' API compatible

* Update documentation with the new function .importOutputForSTClusters()

* Import simulation_variables_names_by_support.csv in data.frame type rather than data.table

* Specify the separator for the simulation_variables_names_by_support.csv import

* Check reverse dependencies

* revdep check ok

* fix rhdf5 call refenrence

* Revdeps ok

* cleaning tests

* add cran-comments

* COMMENT THESE TESTS

* GitHub Actions workflow updated with r-hub v2

* delete package rhdf5 from suggests and delete all functions who use it + delete tests

* cran comment updated with rev dep check ok

* update setsimulation path no more check .h5

* update test to put inside testhat

* comment, cran issue

* update study selection "grep" pattern in tests causing CRAN ISSUE

* add test for path in setSimulationPath() + test + cleaning vignette

* update docs to put values returned + some cleaning references to private function with (:::)

* Fix bad usage of options("warn")

* delete references to .GlobalEnv in test environment

* readAntares() updated to delete `assign` function to modifiy the .GlobalEnv

* delete assign() function and ref to .GlobalEnv

* update cran-comment

* setSimulationPath() delete `getwd()` to choose dir in windows (cran policie)
…licies

Merge branch 'develop' of https://github.com/rte-antares-rpackage/antaresRead into back-propagation

# Conflicts:
#	NAMESPACE
#	NEWS.md
#	R/readBindingConstraints.R
#	R/readClusterDesc.R
#	R/utils_api.R
#	R/zzz.R
#	revdep/README.md
#	tests/testthat/helper_init.R
#	tests/testthat/test-importOutputForClusters.R
#	tests/testthat/test-readAntares_STclusters.R
#	tests/testthat/test-readBindingConstraints.R
#	tests/testthat/test-readClusterDesc.R
#	tests/testthat/test-readInputClusters.R
#	tests/testthat/test-readInputTS.R
#	tests/testthat/test-setSimulationPath.R
#	vignettes/antaresH5.Rmd
@berthetclement berthetclement self-assigned this Sep 2, 2024
@berthetclement berthetclement merged commit bb1ede0 into develop Sep 2, 2024
6 checks passed
@berthetclement berthetclement deleted the back-propagation branch September 2, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant