[readIniFile] : avoid utils::type.convert on specific cases (ex : 789e or 123i)
#247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stand-by for the moment |
Merge branch 'develop' of https://github.com/rte-antares-rpackage/antaresRead into ant1649 # Conflicts: # NEWS.md
boitardn
approved these changes
May 13, 2024
berthetclement
added a commit
that referenced
this pull request
Sep 2, 2024
* update github workflow * Read cluster desc bugfix when cluster exist (#242) * fix bug readClusterDesc when no cluster + cover ST and RES case * add test (init test for thermal + res) * Release/cran261 (#244) (#245) update with developments made during the CRAN release phase * Add argument encoding in api_get() (#246) * Add encoding argument to api_get() * [readIniFile] : avoid `utils::type.convert` on specific cases (ex : 789e or 123i) (#247) * Add specific case to avoid bad convert * Add unit test file for readIniFile * Release/v8.7.0 (#224) ### Breaking changes (Antares v8.7.0) : * `readBindingConstraints()` read now Scenarized RHS for binding constraints (cf. Antares v8.7 changelog) - function returns a new list structure * Private function `fread_antares()` no longer returns warnings * `api_put()/api_delete()` return a server error message BUGFIXES : * `readBindingConstraints()` read well study >= v8.3.2 DATA : * A test study in tar.gz format is available in version v8.7.0 * An empty test study in version v8.7.0 for marginal cases Dependencies : * New package `lifecycle` to manage functions status/package status * Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster (#243) * Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster * .importThermalData fixed to be compatible with data daily format * fix test thermal + add test RES * update * Ant1777/dimbcgroup (#251) * setSimulationPath() updated with new private function to add meta data group dimension for binding constraints * setSimulationPath() doc updated with new parameter * Read ST clusters with readAntares() (#252) * Add .importOutputForSTClusters() * Add 'clustersST' argument in readAntares() * create a wrapper for calling .reshape_details_file() * Simplify .get_value_columns_details_file() with a reference table * Correct areasWithSTClusters parameter in .getSimOptions() * Add unit tests for 'areasWithSTClusters' parameter * Add DETAILS_FILES_TYPE column in the simulation_variables_names_by_support.csv * Update NEWS.md * Make new parameter 'clustersST' API compatible * Update documentation with the new function .importOutputForSTClusters() * Import simulation_variables_names_by_support.csv in data.frame type rather than data.table * Specify the separator for the simulation_variables_names_by_support.csv import * Check reverse dependencies * revdep check ok * fix rhdf5 call refenrence * Revdeps ok * cleaning tests * add cran-comments * COMMENT THESE TESTS * GitHub Actions workflow updated with r-hub v2 * delete package rhdf5 from suggests and delete all functions who use it + delete tests * cran comment updated with rev dep check ok * update setsimulation path no more check .h5 * update test to put inside testhat * comment, cran issue * update study selection "grep" pattern in tests causing CRAN ISSUE * add test for path in setSimulationPath() + test + cleaning vignette * update docs to put values returned + some cleaning references to private function with (:::) * Fix bad usage of options("warn") * delete references to .GlobalEnv in test environment * readAntares() updated to delete `assign` function to modifiy the .GlobalEnv * delete assign() function and ref to .GlobalEnv * update cran-comment * setSimulationPath() delete `getwd()` to choose dir in windows (cran policie)
berthetclement
added a commit
that referenced
this pull request
Sep 2, 2024
* Release/cran261 (#244) * update github workflow * Read cluster desc bugfix when cluster exist (#242) * fix bug readClusterDesc when no cluster + cover ST and RES case * add test (init test for thermal + res) * cleaning * fix cran NOTE causing by bad url in doc + bad doc * Release/cran270 (#249) ### Breaking changes (Antares v8.7.0) : * `readBindingConstraints()` read now Scenarized RHS for binding constraints (cf. Antares v8.7 changelog) - function returns a new list structure * Private function `fread_antares()` no longer returns warnings * `api_put()/api_delete()` return a server error message BUGFIXES : * `readBindingConstraints()` read well study >= v8.3.2 DATA : * A test study in tar.gz format is available in version v8.7.0 * An empty test study in version v8.7.0 for marginal cases Dependencies : * New package `lifecycle` to manage functions status/package status * Releasecran/271 (#253) * update github workflow * Read cluster desc bugfix when cluster exist (#242) * fix bug readClusterDesc when no cluster + cover ST and RES case * add test (init test for thermal + res) * Release/cran261 (#244) (#245) update with developments made during the CRAN release phase * Add argument encoding in api_get() (#246) * Add encoding argument to api_get() * [readIniFile] : avoid `utils::type.convert` on specific cases (ex : 789e or 123i) (#247) * Add specific case to avoid bad convert * Add unit test file for readIniFile * Release/v8.7.0 (#224) ### Breaking changes (Antares v8.7.0) : * `readBindingConstraints()` read now Scenarized RHS for binding constraints (cf. Antares v8.7 changelog) - function returns a new list structure * Private function `fread_antares()` no longer returns warnings * `api_put()/api_delete()` return a server error message BUGFIXES : * `readBindingConstraints()` read well study >= v8.3.2 DATA : * A test study in tar.gz format is available in version v8.7.0 * An empty test study in version v8.7.0 for marginal cases Dependencies : * New package `lifecycle` to manage functions status/package status * Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster (#243) * Dev readInputThermal, add area parameter + parameter thermalavailabilities + default matrix when no time series in cluster * .importThermalData fixed to be compatible with data daily format * fix test thermal + add test RES * update * Ant1777/dimbcgroup (#251) * setSimulationPath() updated with new private function to add meta data group dimension for binding constraints * setSimulationPath() doc updated with new parameter * Read ST clusters with readAntares() (#252) * Add .importOutputForSTClusters() * Add 'clustersST' argument in readAntares() * create a wrapper for calling .reshape_details_file() * Simplify .get_value_columns_details_file() with a reference table * Correct areasWithSTClusters parameter in .getSimOptions() * Add unit tests for 'areasWithSTClusters' parameter * Add DETAILS_FILES_TYPE column in the simulation_variables_names_by_support.csv * Update NEWS.md * Make new parameter 'clustersST' API compatible * Update documentation with the new function .importOutputForSTClusters() * Import simulation_variables_names_by_support.csv in data.frame type rather than data.table * Specify the separator for the simulation_variables_names_by_support.csv import * Check reverse dependencies * revdep check ok * fix rhdf5 call refenrence * Revdeps ok * cleaning tests * add cran-comments * COMMENT THESE TESTS * GitHub Actions workflow updated with r-hub v2 * delete package rhdf5 from suggests and delete all functions who use it + delete tests * cran comment updated with rev dep check ok * update setsimulation path no more check .h5 * update test to put inside testhat * comment, cran issue * update study selection "grep" pattern in tests causing CRAN ISSUE * add test for path in setSimulationPath() + test + cleaning vignette * update docs to put values returned + some cleaning references to private function with (:::) * Fix bad usage of options("warn") * delete references to .GlobalEnv in test environment * readAntares() updated to delete `assign` function to modifiy the .GlobalEnv * delete assign() function and ref to .GlobalEnv * update cran-comment * setSimulationPath() delete `getwd()` to choose dir in windows (cran policie)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.