Save deployments more aggressively #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
commented
Feb 24, 2023
|
|
||
| # write a deployment record only if this is the account that owns the content | ||
| if (is.null(application$owner_username) || |
There was a problem hiding this comment.
When you're deploying to content that you don't own (but still have permission to update), you still want to update the lastSyncTime, bundle id` etc.
aronatkins
approved these changes
Feb 24, 2023
| @@ -1,5 +1,11 @@ | |||
| # rsconnect 0.8.30 (development version) | |||
|
|
|||
| * `deployApp()` is more aggressive about saving deployment data, which should | |||
There was a problem hiding this comment.
aside: I totally missed that we have forgetDeployment to help clean-up those pesky repeats I'm always creating when testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #677. Fixes #270.