Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveDeployment() before upload? #677

Closed
hadley opened this issue Feb 17, 2023 · 0 comments · Fixed by #709
Closed

saveDeployment() before upload? #677

hadley opened this issue Feb 17, 2023 · 0 comments · Fixed by #709
Labels
deploy ⛹️ feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Feb 17, 2023

It's possible for bundling or uploading to fail, which means that you lose useful metadata (e.g. server and account)
Would it make sense to saveDeployment() prior to uploading? e.g.

saveDeployment(
  recordDir,
  target$appName,
  target$appTitle,
  target$username,
  target$account,
  accountDetails$server,
  serverInfo(target$server)$hostUrl,
  application$id,
  NULL, # previously bundle$id
  application$url,
  metadata
)

Would need to verify that you can still resume even when bundle$id is not set. (It doesn't look like deploymentTarget() ever uses bundle$id so maybe this is trivially true?)

@hadley hadley added feature a feature request or enhancement deploy ⛹️ labels Feb 21, 2023
hadley added a commit that referenced this issue Feb 24, 2023
hadley added a commit that referenced this issue Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy ⛹️ feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant