Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detecting external resources needs to consider css argument #2486

Merged
merged 10 commits into from
May 17, 2023
Merged

detecting external resources needs to consider css argument #2486

merged 10 commits into from
May 17, 2023

Commits on May 17, 2023

  1. detecting external resources needs to consider css argument in `out… 

    …put_format` too

This is because `css` can be processed by bslib in pre_knit and/or pre_processor, including when rendering md file in temp directory
    @cderv
    cderv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    ab74581 View commit details
    Browse the repository at this point in the history

  2. only copy resource is required

    @cderv
    cderv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    cb01cb6 View commit details
    Browse the repository at this point in the history

  3. Adapt test to run interactively

    @cderv
    cderv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    07f8bd7 View commit details
    Browse the repository at this point in the history

  4. Add tests and fix code

    @cderv
    cderv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    88cd47a View commit details
    Browse the repository at this point in the history

  5. Add manual tests for shiny issue with resource discovery 

    from #2443 and #2447
    @cderv
    cderv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    67d56ec View commit details
    Browse the repository at this point in the history

  6. adds test for needs_sass

    @cderv
    cderv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    9f13ad2 View commit details
    Browse the repository at this point in the history

  7. Add NEWS

    @cderv
    cderv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    54e98ff View commit details
    Browse the repository at this point in the history

  8. clean comments 

    [skip ci]
    @cderv
    cderv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    9133786 View commit details
    Browse the repository at this point in the history

  9. Update R/html_resources.R 

    Co-authored-by: Yihui Xie <[email protected]>
    @cderv @yihui
    cderv and yihui authored May 17, 2023
    Configuration menu
    Copy the full SHA
    9fd08d8 View commit details
    Browse the repository at this point in the history

  10. Bump version 

    [skip ci]
    @cderv
    cderv committed May 17, 2023
    Configuration menu
    Copy the full SHA
    f55f0c1 View commit details
    Browse the repository at this point in the history