-
-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detecting external resources needs to consider css argument #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put_format` too This is because `css` can be processed by bslib in pre_knit and/or pre_processor, including when rendering md file in temp directory
[skip ci]
Checks triggered manually : https://github.com/rstudio/rmarkdown/actions/runs/5005228987 |
yihui
approved these changes
May 17, 2023
Co-authored-by: Yihui Xie <[email protected]>
[skip ci]
cderv
changed the title
detecting external resources needs to consider css argument in
detecting external resources needs to consider css argument
May 17, 2023
output_format
This was referenced Jun 9, 2023
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Aug 16, 2023
* rstudio/main: start the next version CRAN release v2.24 shinyrmd: Safer dependency extraction from pre-rendered HTML (rstudio#2500) quote the version number per CRAN's request Add output_format_dependency() (rstudio#2462) file_scope is now correctly merged when creating output_format (rstudio#2488) Correctly run some tests only on CI start the next version CRAN release v2.23 remove broken links suggest cleanrmd for e499bf7 add news comparing version numbers with numbers is no longer allowed: https://bugs.r-project.org/show_bug.cgi?id=18548 `find_external_resources` works with custom format using `theme` (rstudio#2494) start the next version CRAN release v2.22 S3 generic/method consistency Change the code-folding button text from "Code" to "Show" (rstudio#2489) fix: bump jquery-ui to v1.13.2 to fix multiple CVEs (rstudio#2477) detecting external resources needs to consider css argument (rstudio#2486)
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Aug 16, 2023
Merge remote-tracking branch 'rstudio/main' into jg-devel # By Yihui Xie (13) and others # Via Yihui Xie * rstudio/main: start the next version CRAN release v2.24 shinyrmd: Safer dependency extraction from pre-rendered HTML (rstudio#2500) quote the version number per CRAN's request Add output_format_dependency() (rstudio#2462) file_scope is now correctly merged when creating output_format (rstudio#2488) Correctly run some tests only on CI start the next version CRAN release v2.23 remove broken links suggest cleanrmd for e499bf7 add news comparing version numbers with numbers is no longer allowed: https://bugs.r-project.org/show_bug.cgi?id=18548 `find_external_resources` works with custom format using `theme` (rstudio#2494) start the next version CRAN release v2.22 S3 generic/method consistency Change the code-folding button text from "Code" to "Show" (rstudio#2489) fix: bump jquery-ui to v1.13.2 to fix multiple CVEs (rstudio#2477) detecting external resources needs to consider css argument (rstudio#2486) # Conflicts: # DESCRIPTION
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because
css
can be processed by bslib in pre_knit and/or pre_processor, including when rendering md file in temp directoryCloses #2443
Closes #2447
The real issue is not with shiny, but rather how renders and resource discovery works when
intermediates_dir
is passed, and when it is another directory. This happens with shiny rendering but could happen in other situations too, not even just when intermediates is a temp directory.Error without shiny example
** rendering
It would happen with
tmp <- "dummy"
too.This happens in our finding resources processing, because we render to an
.md
file in a temp directory, and we need to move the resource in this temp folder at this time.css
orscss
could be processed by bslib or sass in pre_knit and/or pre_processor, including when rendering md file in temp directory. We need to account for this.@cpsievert this PR closes #2448 without merging as this is a broader fix, even when
shiny
is not used.