Revert change about formatting for Pandoc headerless simple table #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
changed the title
This reverts commit e1aebef.
|
in fact this is not the issue with #1954 - Closing. I'll reopen if needed. |
yihui
reviewed
Nov 24, 2020
| @@ -602,7 +602,7 @@ <h2 id="$idprefix$toc-title">$toc-title$</h2> | |||
|
|
|||
| // add bootstrap table styles to pandoc tables | |||
| function bootstrapStylePandocTables() { | |||
| $$('tr.odd').parent('tbody').parent('table').addClass('table table-condensed'); | |||
| $$('tr.header').parent('thead').parent('table').addClass('table table-condensed'); | |||
There was a problem hiding this comment.
How about finding tables that have either thead > tr.header or tbody > tr.odd as their children, and add the classes to them? Would that fix both problems?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1954 by revertgin the change in #1895 for #1894
This reverts commit e1aebef
Should we found another JS solution for #1894 or just document in NEWS.md that one could use
to get the correct formatting for headerless table ?