Support pandoc headerless table in table formatting #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
I'm okay with this PR. Let's wait and see what @fkohrt feels about the JS solution at #1893 (comment).
yihui
approved these changes
Sep 29, 2020
cderv
force-pushed
the
headerless-table
branch
from
5d61795 to
eed2f6c
Compare
|
Great ! I rebased. We wait for CRAN release before adding a bullet to NEWS and merging |
|
v2.4 is on CRAN now: https://cran.r-project.org/package=rmarkdown |
cderv
force-pushed
the
headerless-table
branch
from
eed2f6c to
894ca72
Compare
|
Thanks ! I rebased again and added a NEWS bullet. Feel free to reword in master if necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this one easy to fix #1893 but I agree that this script exists from some time now (#1893 (comment))
pandoc table can have no header so we could point the selector toward another pandoc table specific class.
See https://github.com/jgm/pandoc/blob/9cad5499c45022b9893156bb5e0468cabefca974/src/Text/Pandoc/Writers/HTML.hs#L954
pandoc adds
headerclass totrin table header but it also addodd(oreven) as class intrinsidetbody. We could use that to target pandoc table. But maybe that is more common class addition than the previous selector.As you suggested @yihui we could not add support for that and leave the user customise itself using JS (but it must know how...)
If we want to continue with this PR, I'll add some more tests to be sure.