Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tagFunction() awareness to tag modifying functions #202

Closed
wants to merge 3 commits into from
Closed

Add tagFunction() awareness to tag modifying functions #202

wants to merge 3 commits into from

Conversation

cpsievert
Copy link
Collaborator

TODO: unit tests

schloerke
schloerke reviewed Feb 25, 2021
View reviewed changes
R/tags.R Show resolved Hide resolved
@cpsievert cpsievert marked this pull request as draft February 25, 2021 19:10
@cpsievert cpsievert mentioned this pull request Mar 4, 2021
Merged
@cpsievert cpsievert marked this pull request as ready for review March 17, 2021 15:01
@cpsievert
Provide a default method so as not to break existing code
117e4e0 
(I'm looking at you quillt:::thumbnails)
@cpsievert
Copy link
Collaborator Author

The combination of tagQuery() and tagAddRenderHook() should render this (incomplete) solution redundant

@cpsievert cpsievert closed this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpsievert @schloerke