Provide a default method so as not to break existing code

(I'm looking at you quillt:::thumbnails)
rstudio · Mar 18, 2021 · 02b94e8 · 02b94e8
1 parent d8db18a
commit 02b94e8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -20,9 +20,9 @@ S3method(print,shiny.tag)
 S3method(print,shiny.tag.list)
 S3method(tagAppendAttributes,shiny.tag)
 S3method(tagAppendAttributes,shiny.tag.function)
-S3method(tagAppendChild,shiny.tag)
+S3method(tagAppendChild,default)
 S3method(tagAppendChild,shiny.tag.function)
-S3method(tagAppendChildren,shiny.tag)
+S3method(tagAppendChildren,default)
 S3method(tagAppendChildren,shiny.tag.function)
 S3method(tagSetChildren,shiny.tag)
 S3method(tagSetChildren,shiny.tag.function)

diff --git a/R/tags.R b/R/tags.R
@@ -345,7 +345,7 @@ tagAppendChild <- function(tag, child) {
 }
 
 #' @export
-tagAppendChild.shiny.tag <- function(tag, child) {
+tagAppendChild.default <- function(tag, child) {
   tag$children[[length(tag$children) + 1]] <- child
   tag
 }
@@ -368,7 +368,7 @@ tagAppendChildren <- function(tag, ..., list = NULL) {
 }
 
 #' @export
-tagAppendChildren.shiny.tag <- function(tag, ..., list = NULL) {
+tagAppendChildren.default <- function(tag, ..., list = NULL) {
   tag$children <- unname(c(tag$children, c(dots_list(...), list)))
   tag
 }