Remove bad negative example from capybara sheet #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the bad negative example and adds a new one that still has bad performance. It use to be that `not_to` would wait in a non-performant way: https://www.cloudbees.com/blog/faster-rails-tests but now it it no longer waits: rubocop/rubocop-rspec#378 (comment)
|
@rstacruz, WDYT? |
|
Thanks for this! Sorry it took a while |
ydah
added a commit
to ydah/cheatsheets
that referenced
this pull request
Mar 20, 2024
The above case is a new Bad case added by rstacruz#1798 . It is designated as Bad due to performance issues, but it is not actually a Negative example. In practice, the following would be the same test: ```ruby expect(page).to have_button('Save') !expect(page).to have_button('Save') ``` This is not an example that will appear on the capybara cheat sheet, because it is a problem with how RSpec is written. I think it should be removed because it creates confusion.
rstacruz
pushed a commit
that referenced
this pull request
Mar 21, 2024
) The above case is a new Bad case added by #1798 . It is designated as Bad due to performance issues, but it is not actually a Negative example. In practice, the following would be the same test: ```ruby expect(page).to have_button('Save') !expect(page).to have_button('Save') ``` This is not an example that will appear on the capybara cheat sheet, because it is a problem with how RSpec is written. I think it should be removed because it creates confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the bad negative example and adds a new one that still has bad performance.
It use to be that
not_towould waitin a non-performant way:
https://www.cloudbees.com/blog/faster-rails-tests
but now it it no longer waits:
rubocop/rubocop-rspec#378 (comment)