PP-682/review error handler

[ironFe93]

What

check if an 'error' property is found

Why

In order to throw the correct error

Refs

• (optional: include links to other issues, PRs, tickets, etc)

[ironFe93]

I took the liberty to make a further analysis, here it goes:
There is no endpoint in the server that returns a proper status code when an error happens. All of them catch the error and then send either { message: 'some error' } or { error: 'some error' }

No status code is ever set to 400 or 500, so this catch will never (or rarely) trigger (and if we do get into this catch, we return the request??). This means that we have to explicitly check for an 'error' or 'message' property when handling the response and then throw the error.

We could avoid all of this by returning proper status codes in the server, standardizing the error object (either { error } or { message } ) then letting the request reject (we can catch the error, log it and then throw it).

For the sake of the task, I am checking for { error } or { message } in this PR, which will solve the issue, but I think we can do better.

[antomor]

@ironFe93 Thank you for the in-depth analysis. I'm going to create a task to analyse if we can implement a proper error handler in the server also.
I've just left a small comment, but LGTM 👏🏽