PP-682/review error handler (#79)

* feat: handle errors from server
rsksmart · Mar 10, 2023 · a11522b · a11522b
1 parent 1b3101f
commit a11522b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/api/common/HttpClient.ts b/src/api/common/HttpClient.ts
@@ -16,6 +16,8 @@ type RelayPath = (typeof PATHS)[keyof typeof PATHS];
 type SignedTransactionDetails = {
   transactionHash: string;
   signedTx: string;
+  error?: string;
+  message?: string;
 };
 
 export function buildUrl(base: string, path: string, verifier = ''): string {
@@ -86,13 +88,17 @@ class HttpClient {
   ): Promise<string> {
     const url = buildUrl(relayUrl, PATHS.POST_RELAY_REQUEST);
 
-    const { signedTx } =
+    const { signedTx, error } =
       await this._httpWrapper.sendPromise<SignedTransactionDetails>(
         url,
         this._stringifyEnvelopingTx(envelopingTx)
       );
     log.info('relayTransaction response:', signedTx);
 
+    if (error) {
+      throw new Error(`Got error response from relay: ${error}`);
+    }
+
     if (!signedTx) {
       throw new Error(
         'Got invalid response from relay: signedTx field missing.'

diff --git a/test/api/common/HttpClient.test.ts b/test/api/common/HttpClient.test.ts
@@ -160,6 +160,19 @@ describe('HttpClient', function () {
           httpClient.relayTransaction(fakeURL, request)
         ).to.be.rejectedWith(expectedError);
       });
+
+      it('should throw error if response object contains property `error`', async function () {
+        const serverError = 'error message from server';
+
+        const expectedError = `Got error response from relay: ${serverError}`;
+        sandbox
+          .stub(HttpWrapper.prototype, 'sendPromise')
+          .resolves({ error: serverError });
+
+        await expect(
+          httpClient.relayTransaction(fakeURL, request)
+        ).to.be.rejectedWith(expectedError);
+      });
     });
 
     describe('estimateMaxPossibleGas', function () {